On Thu, Oct 9, 2014 at 1:13 PM, Peter Geoghegan wrote:
>> Can you write
>> a separate patch to use SortSupport for B-tree index builds, please?
>> Eliminating the FunctionCallInfoData overhead should shave off some some
>> cycles from every index build.
>
> I'll look into it. Hopefully an effort t
On Thu, Oct 9, 2014 at 12:51 PM, Heikki Linnakangas
wrote:
> Oh, I didn't realize we don't do that already! I'm surprised, I would've
> expected index build to have been the first thing we'd use the SortSupport
> stuff in.
The thing is that the most compelling numbers for sortsupport (plus
the re
On 10/09/2014 10:25 PM, Peter Geoghegan wrote:
On Thu, Oct 9, 2014 at 12:14 PM, Heikki Linnakangas
wrote:
B-tree index build uses tuplesort.c. What's missing?
I don't think that all that much is missing. Tuplesort expects to work
with an index scankey when sorting B-Tree tuples. There needs t
On Thu, Oct 9, 2014 at 12:14 PM, Heikki Linnakangas
wrote:
> B-tree index build uses tuplesort.c. What's missing?
I don't think that all that much is missing. Tuplesort expects to work
with an index scankey when sorting B-Tree tuples. There needs to be
something like a reverse lookup of the sorts
On 10/09/2014 09:59 PM, Peter Geoghegan wrote:
My concern is that if we only get it committed in the last commitfest,
we may run out of time to make sortsupport work for B-Tree index
builds. That's where the sortsupport for text stuff will be really
useful.
B-tree index build uses tuplesort.c.
On Mon, Oct 6, 2014 at 11:53 AM, Peter Geoghegan wrote:
> On Mon, Oct 6, 2014 at 11:27 AM, Robert Haas wrote:
>> Well, really, I was just suggesting that I can spend more time on the
>> patch, but not immediately.
>
> We haven't really talked about the idea of the HyperLogLog-based abort
> mechan
2014-10-03 23:14 GMT+07:00 Heikki Linnakangas :
> Fix xpath() to return namespace definitions (fixes the issue with nested
> or repeated xpath())
>
> Peter, you've done some XML stuff before; could you have a look at this
> too?
>
I am the author of the patch. I've sent Peter off-the-list revie
On Mon, Oct 6, 2014 at 11:27 AM, Robert Haas wrote:
> Well, really, I was just suggesting that I can spend more time on the
> patch, but not immediately.
We haven't really talked about the idea of the HyperLogLog-based abort
mechanism - the actual cost model - even though I thought we'd have
disc
On Mon, Oct 6, 2014 at 1:58 PM, Peter Geoghegan wrote:
> On Mon, Oct 6, 2014 at 7:57 AM, Robert Haas wrote:
>> I haven't had time to look at it yet. Can we move it to the next
>> CommitFest? I spent a lot of time on this one, but I can't keep doing
>> that forever, because, you know, other work
On Mon, Oct 6, 2014 at 7:57 AM, Robert Haas wrote:
> I haven't had time to look at it yet. Can we move it to the next
> CommitFest? I spent a lot of time on this one, but I can't keep doing
> that forever, because, you know, other work.
Are you suggesting that it would be useful to have input f
On Fri, Oct 3, 2014 at 12:14 PM, Heikki Linnakangas
wrote:
> Sort support for text with strxfrm() poor man's keys
>
> Robert? What do you think of Peter's latest patch?
I haven't had time to look at it yet. Can we move it to the next
CommitFest? I spent a lot of time on this one, but I can't
On 2014-10-03 19:14:14 +0300, Heikki Linnakangas wrote:
> Thanks to everyone's who's reviewed a patch so far. One last crunch, and
> we'll be through.
>
> We have 7 patches left in Needs Review state:
>
> pg_receivexlog: addition of --create/--drop to create/drop repslots
>
> Waiting for Magn
On Fri, Oct 3, 2014 at 6:14 PM, Heikki Linnakangas
wrote:
> Thanks to everyone's who's reviewed a patch so far. One last crunch, and
> we'll be through.
>
> We have 7 patches left in Needs Review state:
>
> pg_receivexlog: addition of --create/--drop to create/drop repslots
>
> Waiting for Magn
Thanks to everyone's who's reviewed a patch so far. One last crunch,
and we'll be through.
We have 7 patches left in Needs Review state:
pg_receivexlog: addition of --create/--drop to create/drop repslots
Waiting for Magnus. Amit promised to take a look if Magnus continues
to be busy.
So
Heikki Linnakangas wrote:
> hash join - dynamic bucket count
> ---
>
> Kevin: Could you review the latest patch, please?
Will post a code review later today. Benchmarks might take a bit
longer...
--
Kevin Grittner
EDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent v
On 09/27/2014 05:12 PM, Tom Lane wrote:
Heikki Linnakangas writes:
[ unreviewed patches ]
Grouping Sets
There has been a lot of discussion, but no decisions. See
http://www.postgresql.org/message-id/87vbodhtvb@news-spur.riddles.org.uk.
Would a committer be interested to take respon
On 9/27/14, 4:18 AM, Heikki Linnakangas wrote:
add latency limit to pgbench throttling (--rate)
---
Rukh: Are you planning to review the latest patch version?
Rukh is free to jump onto this ASAP, but if it's still there next week I
already had my eye on picking that up and taking it out for a
On Sat, Sep 27, 2014 at 1:18 AM, Heikki Linnakangas
wrote:
> Sort support for text with strxfrm() poor man's keys
> ---
>
> Peter: Are you waiting for Robert to review this? Robert, could you review
> the latest patch, please? Peter: Could you try to get rid of the extra
> SortSupport object that
On 2014-09-27 10:12:03 -0400, Tom Lane wrote:
> > Escaping from blocked send() by pg_terminate_backend().
>
> > I've had a look, but I'd like to have a second opinion on this.
>
> I concur with your opinion that this is scary as heck. We need multiple
> pairs of eyeballs if we're going to do any
Heikki Linnakangas writes:
> [ unreviewed patches ]
> Grouping Sets
> There has been a lot of discussion, but no decisions. See
> http://www.postgresql.org/message-id/87vbodhtvb@news-spur.riddles.org.uk.
> Would a committer be interested to take responsibility of this? If not,
> this will
On 09/27/2014 11:31 AM, Andres Freund wrote:
On 2014-09-27 11:18:26 +0300, Heikki Linnakangas wrote:
pg_receivexlog: addition of --create/--drop to create/drop repslots
---
Magnus has promised to review this, but hasn't had the time for weeks. Does
anyone else want to pick this up? I'm OK to wa
On 2014-09-27 11:18:26 +0300, Heikki Linnakangas wrote:
> pg_receivexlog: addition of --create/--drop to create/drop repslots
> ---
>
> Magnus has promised to review this, but hasn't had the time for weeks. Does
> anyone else want to pick this up? I'm OK to wait for Magnus to handle this -
> I exp
We are down to 13 patch in Needs Review state. Many of these are
stragglers that no-one's really even looked at yet.
If we want to finish the commitfest, we'll soon have to decide what to
do to patches that no-one cares enough about to review them.
pg_receivexlog: addition of --create/--dro
23 matches
Mail list logo
