Re: [HACKERS] Label switcher function

2010-12-13 Thread Robert Haas
On Mon, Dec 13, 2010 at 7:17 PM, Robert Haas wrote: > 2010/12/7 KaiGai Kohei : >> Thanks for your reviewing. >> >> The attached patch is a revised version. >> I don't have any objections to your comments. > > This failed to update the security_label docs, but I don't think it's > a requirement tha

Re: [HACKERS] Label switcher function

2010-12-13 Thread Robert Haas
2010/12/7 KaiGai Kohei : > Thanks for your reviewing. > > The attached patch is a revised version. > I don't have any objections to your comments. This failed to update the security_label docs, but I don't think it's a requirement that a hook have regression testing the way we require for an SQL s

Re: [HACKERS] Label switcher function

2010-12-07 Thread KaiGai Kohei
Thanks for your reviewing. The attached patch is a revised version. I don't have any objections to your comments. (2010/12/07 4:38), Robert Haas wrote: > 2010/11/25 KaiGai Kohei: >> The attached patch is a revised one. >> >> It provides two hooks; the one informs core PG whether the supplied >> f

Re: [HACKERS] Label switcher function

2010-12-06 Thread Robert Haas
2010/11/25 KaiGai Kohei : > The attached patch is a revised one. > > It provides two hooks; the one informs core PG whether the supplied > function needs to be hooked, or not. the other is an actual hook on > prepare, start, end and abort of function invocations. > >  typedef bool (*needs_function_

Re: [HACKERS] Label switcher function

2010-11-24 Thread KaiGai Kohei
The attached patch is a revised one. It provides two hooks; the one informs core PG whether the supplied function needs to be hooked, or not. the other is an actual hook on prepare, start, end and abort of function invocations. typedef bool (*needs_function_call_type)(Oid fn_oid); typedef vo

Re: [HACKERS] Label switcher function

2010-11-19 Thread Robert Haas
2010/11/19 KaiGai Kohei : > Indeed, the comment at middle of the fmgr_info_cxt_security() and just > above definition of the fmgr_security_definer() are not correct. > Did you notice anything else? I think I noticed a couple of places, but I didn't write down exactly which ones. Sorry -- Ro

Re: [HACKERS] Label switcher function

2010-11-19 Thread KaiGai Kohei
(2010/11/18 11:30), Robert Haas wrote: > 2010/11/17 KaiGai Kohei: >> I revised my patch as I attached. >> >> The hook function is modified and consolidated as follows: >> >> typedef enum FunctionCallEventType >> { >> FCET_BE_HOOKED, >> FCET_PREPARE, >> FCET_START, >> FCET_EN

Re: [HACKERS] Label switcher function

2010-11-17 Thread Robert Haas
2010/11/17 KaiGai Kohei : > I revised my patch as I attached. > > The hook function is modified and consolidated as follows: > >  typedef enum FunctionCallEventType >  { >     FCET_BE_HOOKED, >     FCET_PREPARE, >     FCET_START, >     FCET_END, >     FCET_ABORT, >  } FunctionCallEventType; > >  ty

Re: [HACKERS] Label switcher function

2010-11-17 Thread Robert Haas
2010/11/17 KaiGai Kohei : > I also fixed up regression test, dummy_seclabel module and its > documentation as Robert pointed out in another topic. I have committed the documentation portion of this patch with some editing. I also fixed the markup, which was broken, because you used _ in several p

Re: [HACKERS] Label switcher function

2010-11-16 Thread KaiGai Kohei
I revised my patch as I attached. The hook function is modified and consolidated as follows: typedef enum FunctionCallEventType { FCET_BE_HOOKED, FCET_PREPARE, FCET_START, FCET_END, FCET_ABORT, } FunctionCallEventType; typedef Datum (*function_call_event_type)(Oi

Re: [HACKERS] Label switcher function

2010-11-13 Thread KaiGai Kohei
(2010/11/14 11:19), Robert Haas wrote: 2010/11/12 KaiGai Kohei: The attached patch allows the security label provider to switch security label of the client during execution of certain functions. I named it as "label switcher function"; also called as "trusted- procedure" in SELinux community.

Re: [HACKERS] Label switcher function

2010-11-13 Thread Robert Haas
2010/11/12 KaiGai Kohei : > The attached patch allows the security label provider to switch > security label of the client during execution of certain functions. > I named it as "label switcher function"; also called as "trusted- > procedure" in SELinux community. > > This feature is quite similar

[HACKERS] Label switcher function

2010-11-12 Thread KaiGai Kohei
The attached patch allows the security label provider to switch security label of the client during execution of certain functions. I named it as "label switcher function"; also called as "trusted- procedure" in SELinux community. This feature is quite similar idea toward security definer function