Andrew Dunstan writes:
> Tom Lane wrote:
>> I'm for forbidding comments on index columns. The amount of work
>> required to support the feature fully seems far out of proportion to
>> its value.
>>
>> In any case, if pg_dump drops such comments (which I had forgotten,
>> but it seems true after
Tom Lane wrote:
I'm for forbidding comments on index columns. The amount of work
required to support the feature fully seems far out of proportion to
its value.
In any case, if pg_dump drops such comments (which I had forgotten,
but it seems true after a quick look at the code), then we coul
Takahiro Itagaki writes:
> Tom Lane wrote:
>> I suggest that we might want to just
>> rip out the support for copying comments on indexes.
> We have two related ToDo items below. They are a bit inconsintent,
> but they mean we should forbid COMMENT on columns of an index,
> or must have full-sup
Tom Lane wrote:
> I suggest that we might want to just
> rip out the support for copying comments on indexes. Or maybe even the
> whole copy-comments aspect of it.
We have two related ToDo items below. They are a bit inconsintent,
but they mean we should forbid COMMENT on columns of an index,
I just got done fixing a different problem in that area, and then I
noticed this:
regression=# create table src (f1 text);
CREATE TABLE
regression=# create index srclower on src(lower(f1));
CREATE INDEX
regression=# comment on column srclower.pg_expression_1 is 'a comment';
COMMENT
regression=# cr
