Re: [HACKERS] Keeping pg_recvlogical's "feTimestamp" separate from TimestampTz

2017-02-18 Thread Tom Lane
I wrote: > I propose that what we need to do is get rid of the dangerous and > none-too-readable-anyway use of "int64" to declare replication-protocol > timestamps, and instead declare them as, say, > typedef struct RPTimestamp > { > int64 rptimestamp; > } RPTimestamp;

[HACKERS] Keeping pg_recvlogical's "feTimestamp" separate from TimestampTz

2017-02-17 Thread Tom Lane
Thomas Munro pointed out that commit 7c030783a broke things on --disable-integer-datetimes builds, because somebody cleverly used TimestampTz to declare timestamp variables, no doubt not having read the comment (which doesn't even appear in the same file :-() that * ... The replication protocol a