Re: [HACKERS] Inheritance, CREATE TABLE LIKE, and partitioned tables

2006-06-26 Thread Bruce Momjian
If you want to merge those functions, please do it as a separate patch now that the patch has been applied. Having too much unrelated stuff in a patch does confuse things. --- Greg Stark wrote: > > Currently analyze.c and

Re: [HACKERS] Inheritance, CREATE TABLE LIKE, and partitioned tables

2006-06-26 Thread Greg Stark
elein <[EMAIL PROTECTED]> writes: > People will turn around and immediately as for create table like without us > making the assumptions it wanted all of the extras that come with inheritance. > COPY is a copy of the table, not additional functionality. The added > flexibility > of adding only w

Re: [HACKERS] Inheritance, CREATE TABLE LIKE, and partitioned tables

2006-06-26 Thread elein
On Mon, Jun 26, 2006 at 12:31:24PM -0400, Greg Stark wrote: > > Currently analyze.c and tablecmds.c both have some very similar code to handle > copying columns from "parent" tables. As long as they were just copying > columns and in the case of tablecmds.c copying check constraints that wasn't >

[HACKERS] Inheritance, CREATE TABLE LIKE, and partitioned tables

2006-06-26 Thread Greg Stark
Currently analyze.c and tablecmds.c both have some very similar code to handle copying columns from "parent" tables. As long as they were just copying columns and in the case of tablecmds.c copying check constraints that wasn't really that bad an idea, the code is pretty simple. However with part