Re: [HACKERS] Inconsistent style in pgbench's error messages

2015-07-06 Thread Tom Lane
Fabien COELHO writes: >> Personally I think "pgbench: " adds very little and so I'd rather get >> rid of it, but I'm sure others feel differently. > I think that one of the reason for this is that once pgbench started to > run it is desirable to differentiate error messages that come from libpq

Re: [HACKERS] Inconsistent style in pgbench's error messages

2015-07-05 Thread Fabien COELHO
Hello Tom, Personally I think "pgbench: " adds very little and so I'd rather get rid of it, but I'm sure others feel differently. I think that one of the reason for this is that once pgbench started to run it is desirable to differentiate error messages that come from libpq and those that c

Re: [HACKERS] Inconsistent style in pgbench's error messages

2015-07-05 Thread Joshua D. Drake
On 07/05/2015 04:46 PM, Tom Lane wrote: I made a pass over pgbench's error messages to try to make them meet project style guidelines. There was one rather large bit of inconsistency that I didn't try to fix, though: something like half of the messages prepend "pgbench: " to the front, but the

[HACKERS] Inconsistent style in pgbench's error messages

2015-07-05 Thread Tom Lane
I made a pass over pgbench's error messages to try to make them meet project style guidelines. There was one rather large bit of inconsistency that I didn't try to fix, though: something like half of the messages prepend "pgbench: " to the front, but the other half don't. Worse yet, some of the o