Re: [HACKERS] Inconsistency in extended-query-protocol

2006-09-14 Thread Bruce Momjian
Tom Lane wrote: > "Guillaume Smet" <[EMAIL PROTECTED]> writes: > > On 9/13/06, Tom Lane <[EMAIL PROTECTED]> wrote: > >> statement: querystring Simple Query > >> parse : querystring Parse > >> bind /: querystring Bind > >> execute /: querystringExecute > > >

Re: [HACKERS] Inconsistency in extended-query-protocol logging

2006-09-13 Thread Tom Lane
"Guillaume Smet" <[EMAIL PROTECTED]> writes: > On 9/13/06, Tom Lane <[EMAIL PROTECTED]> wrote: >> statement: querystring Simple Query >> parse : querystring Parse >> bind /: querystring Bind >> execute /: querystringExecute > I agree with that. OK, Bruce h

Re: [HACKERS] Inconsistency in extended-query-protocol logging

2006-09-13 Thread Guillaume Smet
On 9/13/06, Tom Lane <[EMAIL PROTECTED]> wrote: statement: querystring Simple Query parse : querystring Parse bind /: querystring Bind execute /: querystringExecute I agree with that. Hmmm, AFAICS, you changed "/" to " to

Re: [HACKERS] Inconsistency in extended-query-protocol logging

2006-09-13 Thread Tom Lane
"Guillaume Smet" <[EMAIL PROTECTED]> writes: > IMHO, it's more logical to remove it as the text after statement: is > not a statement in the extended query protocol case. Well, I was never particularly enamored of the idea that we should put statement: into everything generated by log_statement.

Re: [HACKERS] Inconsistency in extended-query-protocol logging

2006-09-13 Thread Guillaume Smet
On 9/13/06, Tom Lane <[EMAIL PROTECTED]> wrote: "Guillaume Smet" <[EMAIL PROTECTED]> writes: > I attached a patch to improve the consistency. It adds statement: for > every case. Isn't that just bloating the log? And weren't you the one complaining about log volumes to begin with? As I told y

Re: [HACKERS] Inconsistency in extended-query-protocol logging

2006-09-13 Thread Tom Lane
"Guillaume Smet" <[EMAIL PROTECTED]> writes: > I attached a patch to improve the consistency. It adds statement: for > every case. Isn't that just bloating the log? And weren't you the one complaining about log volumes to begin with? The reason it is why it is is that Bruce wanted the wording to

[HACKERS] Inconsistency in extended-query-protocol logging

2006-09-13 Thread Guillaume Smet
Tom, I'm currently resyncing my parser with the changes you made to prepared statement logging. Everything is OK apart from an inconsistency between log_duration and log_min_duration_statement. * With log_duration, we have: protocol : LOG: statement: execute my_query: SELECT * FROM shop WHERE $