Re: [HACKERS] INSERT ON CONFLICT and partitioned tables

2017-08-03 Thread Jeevan Ladhe
Thanks Amit for addressing the comment. The patch looks good to me. I have no more comments. Verified that v2 patch applies cleanly and make check passes. Thanks, Jeevan Ladhe

Re: [HACKERS] INSERT ON CONFLICT and partitioned tables

2017-08-02 Thread Amit Langote
Thanks Jeevan for looking at this. See comments below. On 2017/08/02 19:04, Jeevan Ladhe wrote: > On Wed, Aug 2, 2017 at 10:26 AM, Amit Langote wrote: >> The patch's job is simple: >> >> - Remove the check in the parser that causes an error the moment the >> ON CONFLICT clause is found. >> >> -

Re: [HACKERS] INSERT ON CONFLICT and partitioned tables

2017-08-02 Thread Jeevan Ladhe
I applied the patch on latest master sources and the patch applies cleanly. The documentation is built without errors. We do not support following syntax for 'do nothing': postgres=# insert into parted_conflict_test values (1, 'a') on conflict (b) do nothing; ERROR: there is no unique or exclusi

[HACKERS] INSERT ON CONFLICT and partitioned tables

2017-08-01 Thread Amit Langote
Starting a new thread for a patch I posted earlier [1] to handle ON CONFLICT DO NOTHING when inserting into a partitioned table. It's intended for PG 11 and so registered in the upcoming CF. Summary of the previous discussion and the patch for anyone interested: Currently, if an INSERT statement