Re: [HACKERS] Hot standby, pausing recovery

2009-10-20 Thread Simon Riggs
On Tue, 2009-10-20 at 09:43 +0100, Simon Riggs wrote: > On Tue, 2009-10-20 at 10:33 +0300, Heikki Linnakangas wrote: > > At this point, I'd like to cut out all those control functions to > > pause/stop at various points from the patch. > > OK Maybe OK, I should say. Some parts are important for t

Re: [HACKERS] Hot standby, pausing recovery

2009-10-20 Thread Simon Riggs
On Tue, 2009-10-20 at 10:33 +0300, Heikki Linnakangas wrote: > At this point, I'd like to cut out all those control functions to > pause/stop at various points from the patch. OK -- Simon Riggs www.2ndQuadrant.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org

Re: [HACKERS] Hot standby, pausing recovery

2009-10-20 Thread Heikki Linnakangas
Simon Riggs wrote: > On Fri, 2009-10-16 at 09:33 +0300, Heikki Linnakangas wrote: >> If you pause recovery, and then continue, we reset to "target none" >> mode, even if a stopping point was set previously. > > Yes, currently. Resetting the target mode will do what you want, rather > than continu

Re: [HACKERS] Hot standby, pausing recovery

2009-10-16 Thread Simon Riggs
On Fri, 2009-10-16 at 09:33 +0300, Heikki Linnakangas wrote: > In advance-mode, we will merrilly skip over a WAL record that's a > recovery stop target. Is that a bug or a feature? Merrily?!? I saw it more as a sombre stepping motion. Advance currently means set target at next record and continu

[HACKERS] Hot standby, pausing recovery

2009-10-15 Thread Heikki Linnakangas
This if-block is misplaced: > case RECOVERY_TARGET_STOP_IMMEDIATE: > case RECOVERY_TARGET_STOP_XID: > case RECOVERY_TARGET_STOP_TIME: > paused = false; > br