Re: [HACKERS] Hot standby, freezing

2009-11-11 Thread Simon Riggs
On Wed, 2009-11-11 at 12:35 +0200, Heikki Linnakangas wrote: > While reading through the patch for what must be the 100th time by now, :-) > it occurred to me that this comment in heap_xlog_freeze: > > + /* > +* Freezing tuples does not require conflict processing > +*/ >

[HACKERS] Hot standby, freezing

2009-11-11 Thread Heikki Linnakangas
While reading through the patch for what must be the 100th time by now, it occurred to me that this comment in heap_xlog_freeze: + /* +* Freezing tuples does not require conflict processing +*/ is plain wrong. In the master, we can freeze the xmin of a tuple that's not yet v