> On 13 Sep 2017, at 15:01, Tomas Vondra wrote:
>
> On 09/13/2017 07:53 AM, Andrey Borodin wrote:
>>> * I see there are conditions like this:
>>>
>>>if(xlogreader->blocks[nblock].forknum == MAIN_FORKNUM)
>>>
>>> Why is it enough to restrict the block-tracking code to main fork?
>>> Aren't w
On 09/13/2017 07:53 AM, Andrey Borodin wrote:
>> * I see there are conditions like this:
>>
>> if(xlogreader->blocks[nblock].forknum == MAIN_FORKNUM)
>>
>> Why is it enough to restrict the block-tracking code to main fork?
>> Aren't we interested in all relation forks?
> fsm, vm and others are
Hi!
Thank you for your interest and experiment results.
> 13 сент. 2017 г., в 15:43, Ants Aasma написал(а):
>
> On Thu, Aug 31, 2017 at 9:02 AM, Andrey Borodin wrote:
>> When we have accumulated diff blocknumbers for most of segments we can
>> significantly speed up method of WAL scanning. If w
On Thu, Aug 31, 2017 at 9:02 AM, Andrey Borodin wrote:
> When we have accumulated diff blocknumbers for most of segments we can
> significantly speed up method of WAL scanning. If we have blocknumbers for
> all segments we can skip WAL scanning at all.
Have you measured that the WAL scanning is
Hi Tomas! Thank you for looking into that patch.
> 8 сент. 2017 г., в 1:53, Tomas Vondra
> написал(а):
>
> A few more comments:
>
> * The patch defines wal_switch_hook, but it's never called.
That call was missing, that's a bug, thanks for spotting that out.
> * I see there are conditions lik
Hi,
On 09/01/2017 08:13 AM, Andrey Borodin wrote:
> Thank you for your reply, Michael! Your comments are valuable,
especially in the world of backups.
>
>> 31 авг. 2017 г., в 19:44, Michael Paquier
написал(а):
>> Such things are not Postgres-C like.
> Will be fixed.
>
A few more comments:
* The
Thank you for your reply, Michael! Your comments are valuable, especially in
the world of backups.
> 31 авг. 2017 г., в 19:44, Michael Paquier
> написал(а):
> Such things are not Postgres-C like.
Will be fixed.
> I don't understand what xlog_begin_insert_hook() is good for.
memset control str
On Thu, Aug 31, 2017 at 3:02 PM, Andrey Borodin wrote:
> Here is the patch with hooks that I consider sufficient for implementation of
> incremental backup with pages tracking as extension.
>
> Recently I was posting these things to the thread "Adding hook in BufferSync
> for backup purposes" [0
Hi hackers!
Here is the patch with hooks that I consider sufficient for implementation of
incremental backup with pages tracking as extension.
Recently I was posting these things to the thread "Adding hook in BufferSync
for backup purposes" [0], but here I start separate thread since Subj field
