On 2017/08/17 1:31, Tom Lane wrote:
postgres_fdw.c around line 4500:
/*
* If there is a possibility that EvalPlanQual will be executed, we need
* to be able to reconstruct the row using scans of the base relations.
* GetExistingLocalJoinPath will find a suitable path for t
Robert Haas writes:
> On Wed, Aug 16, 2017 at 3:44 PM, Tom Lane wrote:
>> Will you fix it, or shall I?
> Whichever you like.
It's your commit, you can do the honors.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make chang
On Wed, Aug 16, 2017 at 3:44 PM, Tom Lane wrote:
> Robert Haas writes:
>> On Wed, Aug 16, 2017 at 3:02 PM, Robert Haas wrote:
>>> On Wed, Aug 16, 2017 at 2:16 PM, Tom Lane wrote:
The current text of the comment dates to commit 177c56d60, and looking at
that commit makes it pretty clea
Robert Haas writes:
> On Wed, Aug 16, 2017 at 3:02 PM, Robert Haas wrote:
>> On Wed, Aug 16, 2017 at 2:16 PM, Tom Lane wrote:
>>> The current text of the comment dates to commit 177c56d60, and looking at
>>> that commit makes it pretty clear that the line I'm complaining of
>>> belonged to the p
On Wed, Aug 16, 2017 at 3:02 PM, Robert Haas wrote:
> On Wed, Aug 16, 2017 at 2:16 PM, Tom Lane wrote:
>> Robert Haas writes:
>>> On Wed, Aug 16, 2017 at 12:31 PM, Tom Lane wrote:
--> * reconstruct the row for EvalPlanQual(). Find an alternative local
path
Should the marked lin
On Wed, Aug 16, 2017 at 2:16 PM, Tom Lane wrote:
> Robert Haas writes:
>> On Wed, Aug 16, 2017 at 12:31 PM, Tom Lane wrote:
>>> --> * reconstruct the row for EvalPlanQual(). Find an alternative local
>>> path
>>> Should the marked line simply be deleted? If not, what correction is
>>> appropr
Robert Haas writes:
> On Wed, Aug 16, 2017 at 12:31 PM, Tom Lane wrote:
>> --> * reconstruct the row for EvalPlanQual(). Find an alternative local path
>> Should the marked line simply be deleted? If not, what correction is
>> appropriate?
> Hmm, wow. My first thought was that it should just
On Wed, Aug 16, 2017 at 12:31 PM, Tom Lane wrote:
> postgres_fdw.c around line 4500:
>
> /*
> * If there is a possibility that EvalPlanQual will be executed, we need
> * to be able to reconstruct the row using scans of the base relations.
> * GetExistingLocalJoinPath will find a
postgres_fdw.c around line 4500:
/*
* If there is a possibility that EvalPlanQual will be executed, we need
* to be able to reconstruct the row using scans of the base relations.
* GetExistingLocalJoinPath will find a suitable path for this purpose in
* the path list of the
