Re: [HACKERS] GIN pageinspect functions

2015-08-10 Thread Jeff Janes
On Fri, Nov 21, 2014 at 2:04 AM, Heikki Linnakangas wrote: > On 11/20/2014 05:52 AM, Michael Paquier wrote: > >> On Wed, Nov 19, 2014 at 7:01 AM, Peter Geoghegan wrote: >> >>> On Tue, Nov 4, 2014 at 7:26 AM, Amit Kapila >>> wrote: >>> 1. Documentation seems to be missing, other API's exposed >>

Re: [HACKERS] GIN pageinspect functions

2014-11-21 Thread Heikki Linnakangas
On 11/20/2014 05:52 AM, Michael Paquier wrote: On Wed, Nov 19, 2014 at 7:01 AM, Peter Geoghegan wrote: On Tue, Nov 4, 2014 at 7:26 AM, Amit Kapila wrote: 1. Documentation seems to be missing, other API's exposed via pageinspect are documented at: http://www.postgresql.org/docs/devel/static/pag

Re: [HACKERS] GIN pageinspect functions

2014-11-19 Thread Michael Paquier
On Wed, Nov 19, 2014 at 7:01 AM, Peter Geoghegan wrote: > On Tue, Nov 4, 2014 at 7:26 AM, Amit Kapila wrote: >> I think these functions will be quite useful for debugging purpose >> and we already have similar function's for other index (btree). > > This patch has bitrotted. I attach rebased revi

Re: [HACKERS] GIN pageinspect functions

2014-11-18 Thread Peter Geoghegan
On Tue, Nov 18, 2014 at 2:01 PM, Peter Geoghegan wrote: > Do you intend to fix this up? BTW, how do you feel about the B-Tree check extension [1]? It's very much related to pageinspect -- it's more or less a derivative. I don't think I'm going to have time (or that there is sufficient review band

Re: [HACKERS] GIN pageinspect functions

2014-11-18 Thread Peter Geoghegan
On Tue, Nov 4, 2014 at 7:26 AM, Amit Kapila wrote: > I think these functions will be quite useful for debugging purpose > and we already have similar function's for other index (btree). This patch has bitrotted. I attach rebased revision, for the convenience of others - V1.3 of pageinspect will n

Re: [HACKERS] GIN pageinspect functions

2014-11-04 Thread Amit Kapila
On Tue, Oct 7, 2014 at 10:33 PM, Heikki Linnakangas wrote: > > Some time ago, when debugging a GIN bug, I wrote these pageinspect functions to inspect GIN indexes. They were very useful; we should add them. > I think these functions will be quite useful for debugging purpose and we already have s

Re: [HACKERS] GIN pageinspect functions

2014-10-07 Thread Oleg Bartunov
On Tue, Oct 7, 2014 at 9:56 PM, Heikki Linnakangas wrote: > On 10/07/2014 08:36 PM, Oleg Bartunov wrote: > >> On Tue, Oct 7, 2014 at 9:03 PM, Heikki Linnakangas < >> hlinnakan...@vmware.com> >> wrote: >> >> Some time ago, when debugging a GIN bug, I wrote these pageinspect >>> functions to inspe

Re: [HACKERS] GIN pageinspect functions

2014-10-07 Thread Heikki Linnakangas
On 10/07/2014 08:36 PM, Oleg Bartunov wrote: On Tue, Oct 7, 2014 at 9:03 PM, Heikki Linnakangas wrote: Some time ago, when debugging a GIN bug, I wrote these pageinspect functions to inspect GIN indexes. They were very useful; we should add them. May be we can merge it with contrib/gevel, w

Re: [HACKERS] GIN pageinspect functions

2014-10-07 Thread Oleg Bartunov
On Tue, Oct 7, 2014 at 9:03 PM, Heikki Linnakangas wrote: > Some time ago, when debugging a GIN bug, I wrote these pageinspect > functions to inspect GIN indexes. They were very useful; we should add them. > May be we can merge it with contrib/gevel, which we use many years for development and d

[HACKERS] GIN pageinspect functions

2014-10-07 Thread Heikki Linnakangas
Some time ago, when debugging a GIN bug, I wrote these pageinspect functions to inspect GIN indexes. They were very useful; we should add them. - Heikki >From 91ef58aab11e9077ab6a38268a1120806e42f2dd Mon Sep 17 00:00:00 2001 From: Heikki Linnakangas Date: Fri, 12 Sep 2014 13:36:30 +0300 Subject