Re: [HACKERS] GIN improvements part 3: ordering in index

2013-07-06 Thread Tomas Vondra
Hi, this is a follow-up to the message I posted to the thread about additional info in GIN. I've applied all three patches (ginaddinfo7.patch, gin_fast_scan.4.patch and gin_ordering.4.patch) onto commit b8fd1a09. I ended up with two definitions of ‘cmpEntries’ in ginget.c, but I suppose this is d

Re: [HACKERS] GIN improvements part 3: ordering in index

2013-07-01 Thread Alexander Korotkov
On Sun, Jun 30, 2013 at 3:09 PM, Heikki Linnakangas wrote: > On 25.06.2013 21:18, Alexander Korotkov wrote: > >> On Tue, Jun 25, 2013 at 7:31 PM, Heikki Linnakangas> vmware.com >> >>> wrote: >>> >> >> In summary: The test case you presented as motivation for this patch is a >>> bit of a worst-c

Re: [HACKERS] GIN improvements part 3: ordering in index

2013-06-30 Thread Heikki Linnakangas
On 25.06.2013 21:18, Alexander Korotkov wrote: On Tue, Jun 25, 2013 at 7:31 PM, Heikki Linnakangas wrote: In summary: The test case you presented as motivation for this patch is a bit of a worst-case scenario for the current tidbitmap implementation. The speedup from your patch comes from avoi

Re: [HACKERS] GIN improvements part 3: ordering in index

2013-06-25 Thread Alexander Korotkov
On Tue, Jun 25, 2013 at 7:31 PM, Heikki Linnakangas wrote: > On 25.06.2013 01:24, Alexander Korotkov wrote: > >> On Wed, Jun 19, 2013 at 1:21 AM, Alexander Korotkov >> **wrote: >> >> On Mon, Jun 17, 2013 at 10:27 PM, Heikki Linnakangas< >>> hlinnakan...@vmware.com> wrote: >>> >>> That has some

Re: [HACKERS] GIN improvements part 3: ordering in index

2013-06-25 Thread Heikki Linnakangas
On 25.06.2013 01:24, Alexander Korotkov wrote: On Wed, Jun 19, 2013 at 1:21 AM, Alexander Korotkovwrote: On Mon, Jun 17, 2013 at 10:27 PM, Heikki Linnakangas< hlinnakan...@vmware.com> wrote: That has some obvious limitations. First of all, you can run out of memory. Yes, it is so. qsort sh

Re: [HACKERS] GIN improvements part 3: ordering in index

2013-06-24 Thread Alexander Korotkov
On Wed, Jun 19, 2013 at 1:21 AM, Alexander Korotkov wrote: > On Mon, Jun 17, 2013 at 10:27 PM, Heikki Linnakangas < > hlinnakan...@vmware.com> wrote: > >> On 17.06.2013 15:56, Alexander Korotkov wrote: >> >>> On Sat, Jun 15, 2013 at 3:02 AM, Alexander Korotkov>> >**wrote: >>> >>> This patch intro

Re: [HACKERS] GIN improvements part 3: ordering in index

2013-06-18 Thread Alexander Korotkov
On Mon, Jun 17, 2013 at 10:27 PM, Heikki Linnakangas < hlinnakan...@vmware.com> wrote: > On 17.06.2013 15:56, Alexander Korotkov wrote: > >> On Sat, Jun 15, 2013 at 3:02 AM, Alexander Korotkov >> **wrote: >> >> This patch introduces new interface method of GIN which takes same >>> arguments as co

Re: [HACKERS] GIN improvements part 3: ordering in index

2013-06-17 Thread Heikki Linnakangas
On 17.06.2013 15:56, Alexander Korotkov wrote: On Sat, Jun 15, 2013 at 3:02 AM, Alexander Korotkovwrote: This patch introduces new interface method of GIN which takes same arguments as consistent but returns float8. float8 gin_ordering(bool check[], StrategyNumber n, Datum query, int32 nkeys, P

Re: [HACKERS] GIN improvements part 3: ordering in index

2013-06-17 Thread Alexander Korotkov
On Sat, Jun 15, 2013 at 3:02 AM, Alexander Korotkov wrote: > attached patch implementing ordering inside GIN index. This is third patch > of GIN improvements, see previous two: > > http://www.postgresql.org/message-id/capphfduxv-il7aedwpw0w5fxrwgakfxijwm63_hzujacrxn...@mail.gmail.com > > http://ww

[HACKERS] GIN improvements part 3: ordering in index

2013-06-14 Thread Alexander Korotkov
Hackers, attached patch implementing ordering inside GIN index. This is third patch of GIN improvements, see previous two: http://www.postgresql.org/message-id/capphfduxv-il7aedwpw0w5fxrwgakfxijwm63_hzujacrxn...@mail.gmail.com http://www.postgresql.org/message-id/CAPpHfdvftaJq7www381naLw1=4u0h+qpx