Re: [HACKERS] Fwd: Re: [DOCS] Document Upper Limit for NAMEDATELEN in pgsql 9.5+

2016-01-22 Thread Tom Lane
Robert Haas writes: > Actually, though, varstr_levenshtein_less_equal() never gets called > from parse_relation.c with a distance bound of more than four, so it > can't actually go quadratic. There's another call in that file to > varstr_levenshtein(), which in retrospect looks silly, but I'm pre

Re: [HACKERS] Fwd: Re: [DOCS] Document Upper Limit for NAMEDATELEN in pgsql 9.5+

2016-01-10 Thread Robert Haas
On Fri, Jan 8, 2016 at 3:05 PM, Tom Lane wrote: > [ redirecting from -docs, which isn't the best place to discuss code fixes ] > > Whoever thought this was a good idea: > > StaticAssertStmt(NAMEDATALEN <= MAX_LEVENSHTEIN_STRLEN, > "Levenshtein hinting mechanism restricts N

Re: [HACKERS] Fwd: Re: [DOCS] Document Upper Limit for NAMEDATELEN in pgsql 9.5+

2016-01-08 Thread Peter Geoghegan
On Fri, Jan 8, 2016 at 12:05 PM, Tom Lane wrote: > Whoever thought this was a good idea: > > StaticAssertStmt(NAMEDATALEN <= MAX_LEVENSHTEIN_STRLEN, > "Levenshtein hinting mechanism restricts NAMEDATALEN"); > > is nuts. Then I must be nuts. > A minimal fix that would not

[HACKERS] Fwd: Re: [DOCS] Document Upper Limit for NAMEDATELEN in pgsql 9.5+

2016-01-08 Thread Tom Lane
[ redirecting from -docs, which isn't the best place to discuss code fixes ] Whoever thought this was a good idea: StaticAssertStmt(NAMEDATALEN <= MAX_LEVENSHTEIN_STRLEN, "Levenshtein hinting mechanism restricts NAMEDATALEN"); is nuts. A minimal fix that would not put s