Ali Akbar writes:
> Just curious, in accumArrayResultArr, while enlarging array and
> nullbitmaps, why it's implemented with:
> astate->abytes = Max(astate->abytes * 2,
> astate->nbytes + ndatabytes);
> and
> astate->aitems = Max(astate->aitems * 2, newnitems);
> won't it be more consistent if i
2014-11-26 0:38 GMT+07:00 Tom Lane :
> Pavel Stehule writes:
> > 2014-10-27 11:20 GMT+01:00 Ali Akbar :
> >> [ array_agg_anyarray-13.patch ]
>
> > This patch is ready for commit
>
> I've committed this after some significant modifications.
>
> I did not like the API chosen, specifically the busin
Pavel Stehule writes:
> 2014-10-27 11:20 GMT+01:00 Ali Akbar :
>> [ array_agg_anyarray-13.patch ]
> This patch is ready for commit
I've committed this after some significant modifications.
I did not like the API chosen, specifically the business about callers
needing to deal with both accumArra
>
> super
>
> I tested last version and I have not any objections.
>
> 1. We would to have this feature - it is long time number of our ToDo List
>
> 2. Proposal and design of multidimensional aggregation is clean and nobody
> has objection here.
>
> 3. There is zero impact on current implementatio
2014-10-27 11:20 GMT+01:00 Ali Akbar :
>
> 2014-10-27 16:15 GMT+07:00 Pavel Stehule :
>
>> Hi
>>
>> I did some minor changes in code
>>
>> * move tests of old or new builder style for array sublink out of main
>> cycles
>> * some API simplification of new builder - we should not to create
>> ident
2014-10-27 16:15 GMT+07:00 Pavel Stehule :
> Hi
>
> I did some minor changes in code
>
> * move tests of old or new builder style for array sublink out of main
> cycles
> * some API simplification of new builder - we should not to create
> identical API, mainly it has no sense
>
minor changes in
Hi
I did some minor changes in code
* move tests of old or new builder style for array sublink out of main
cycles
* some API simplification of new builder - we should not to create
identical API, mainly it has no sense
Regards
Pavel Stehule
2014-10-27 8:12 GMT+01:00 Ali Akbar :
> 2014-10-27
2014-10-27 9:11 GMT+07:00 Ali Akbar :
>
> 2014-10-27 1:38 GMT+07:00 Pavel Stehule :
>
>> Hi
>>
>> My idea is using new ArrayBuilder optimized for building multidimensional
>> arrays with own State type. I think so casting to ArrayBuildState is base
>> of our problems, so I don't would to do. Code
2014-10-27 1:38 GMT+07:00 Pavel Stehule :
> Hi
>
> My idea is using new ArrayBuilder optimized for building multidimensional
> arrays with own State type. I think so casting to ArrayBuildState is base
> of our problems, so I don't would to do. Code in array_agg_* is simple,
> little bit more compl
Hi
My idea is using new ArrayBuilder optimized for building multidimensional
arrays with own State type. I think so casting to ArrayBuildState is base
of our problems, so I don't would to do. Code in array_agg_* is simple,
little bit more complex code is in nodeSubplan.c. Some schematic changes
ar
>
> you can check it? We can test, how performance lost we get. As second
> benefit we can get numbers for introduction new optimized array builder
>
array_agg(anyarray) with deconstruct_array, unchanged accumArrayResult and
makeMdArrayResult:
> INSERT 0 1
> Time: 852,527 ms
> INSERT 0 1
> Time:
2014-10-25 12:20 GMT+02:00 Ali Akbar :
> 2014-10-25 15:43 GMT+07:00 Pavel Stehule :
>
>>
>>
>> 2014-10-25 10:16 GMT+02:00 Ali Akbar :
>>
>>> makeArrayResult1 - I have no better name now
>
> I found one next minor detail.
>
> you reuse a array_agg_transfn function. Inside is a mess
2014-10-25 15:43 GMT+07:00 Pavel Stehule :
>
>
> 2014-10-25 10:16 GMT+02:00 Ali Akbar :
>
>> makeArrayResult1 - I have no better name now
I found one next minor detail.
you reuse a array_agg_transfn function. Inside is a message
"array_agg_transfn called in non-aggregate
2014-10-25 10:16 GMT+02:00 Ali Akbar :
> makeArrayResult1 - I have no better name now
>>>
>>> I found one next minor detail.
>>>
>>> you reuse a array_agg_transfn function. Inside is a message
>>> "array_agg_transfn called in non-aggregate context". It is not correct for
>>> array_agg_anyarray_tr
>
> makeArrayResult1 - I have no better name now
>>
>> I found one next minor detail.
>>
>> you reuse a array_agg_transfn function. Inside is a message
>> "array_agg_transfn called in non-aggregate context". It is not correct for
>> array_agg_anyarray_transfn
>>
>
Fixed.
> probably specification
2014-10-25 8:33 GMT+02:00 Pavel Stehule :
>
>
> 2014-10-25 8:19 GMT+02:00 Ali Akbar :
>
>> 2014-10-25 10:29 GMT+07:00 Ali Akbar :
>>
>>> I fixed small issue in regress tests and I enhanced tests for varlena
types and null values.
>>>
>>> Thanks.
>>>
>>> it is about 15% faster than original im
2014-10-25 8:19 GMT+02:00 Ali Akbar :
> 2014-10-25 10:29 GMT+07:00 Ali Akbar :
>
>> I fixed small issue in regress tests and I enhanced tests for varlena
>>> types and null values.
>>
>> Thanks.
>>
>> it is about 15% faster than original implementation.
>>
>> 15% faster than array_agg(scalar)? I h
2014-10-25 10:29 GMT+07:00 Ali Akbar :
> I fixed small issue in regress tests and I enhanced tests for varlena
>> types and null values.
>
> Thanks.
>
> it is about 15% faster than original implementation.
>
> 15% faster than array_agg(scalar)? I haven't verify the performance, but
> because the i
>
> I fixed small issue in regress tests and I enhanced tests for varlena
> types and null values.
Thanks.
it is about 15% faster than original implementation.
15% faster than array_agg(scalar)? I haven't verify the performance, but
because the internal array data and null bitmap is copied as-is
Hi Ali
I checked a code. I am thinking so code organization is not good.
accumArrayResult is too long now. makeMdArrayResult will not work, when
arrays was joined (it is not consistent now). I don't like a usage of
state->is_array_accum in array_userfunc.c -- it is signal of wrong
wrapping.
next
2014-10-24 13:58 GMT+02:00 Pavel Stehule :
>
>
> 2014-10-24 11:43 GMT+02:00 Ali Akbar :
>
>>
>> 2014-10-24 16:26 GMT+07:00 Pavel Stehule :
>>
>>> Hi
>>>
>>> some in last patch is wrong, I cannot to compile it:
>>>
>>> arrayfuncs.c: In function ‘accumArrayResult’:
>>> arrayfuncs.c:4603:9: error: ‘A
Michael Paquier wrote:
> That's not surprising, sometimes filterdiff misses the shot.
Really? Wow, that's bad news. I've been using it to submit patches
from time to time ...
--
Álvaro Herrerahttp://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
Hi
I did some performance tests and it is interesting:
it is about 15% faster than original implementation.
Regards
Pavel
2014-10-24 13:58 GMT+02:00 Pavel Stehule :
>
>
> 2014-10-24 11:43 GMT+02:00 Ali Akbar :
>
>>
>> 2014-10-24 16:26 GMT+07:00 Pavel Stehule :
>>
>>> Hi
>>>
>>> some in las
2014-10-24 11:43 GMT+02:00 Ali Akbar :
>
> 2014-10-24 16:26 GMT+07:00 Pavel Stehule :
>
>> Hi
>>
>> some in last patch is wrong, I cannot to compile it:
>>
>> arrayfuncs.c: In function ‘accumArrayResult’:
>> arrayfuncs.c:4603:9: error: ‘ArrayBuildState’ has no member named ‘alen’
>>astate->ale
On Fri, Oct 24, 2014 at 11:43 AM, Ali Akbar wrote:
>
> 2014-10-24 16:26 GMT+07:00 Pavel Stehule :
>
>> Hi
>>
>> some in last patch is wrong, I cannot to compile it:
>>
>> arrayfuncs.c: In function 'accumArrayResult':
>> arrayfuncs.c:4603:9: error: 'ArrayBuildState' has no member named 'alen'
>>
2014-10-24 16:26 GMT+07:00 Pavel Stehule :
> Hi
>
> some in last patch is wrong, I cannot to compile it:
>
> arrayfuncs.c: In function ‘accumArrayResult’:
> arrayfuncs.c:4603:9: error: ‘ArrayBuildState’ has no member named ‘alen’
>astate->alen = 64; /* arbitrary starting array size */
>
Hi
some in last patch is wrong, I cannot to compile it:
arrayfuncs.c: In function ‘accumArrayResult’:
arrayfuncs.c:4603:9: error: ‘ArrayBuildState’ has no member named ‘alen’
astate->alen = 64; /* arbitrary starting array size */
^
arrayfuncs.c:4604:9: error: ‘ArrayBuildState’ has no
2014-10-24 15:48 GMT+07:00 Pavel Stehule :
> Hi
>
> it looks well
>
> doc:
> http://www.postgresql.org/docs/9.4/static/sql-expressions.html#SQL-SYNTAX-ARRAY-CONSTRUCTORS
> it should be fixed too
>
> Regards
>
> Pavel
>
doc updated with additional example for array(subselect). patch attached.
Reg
Hi
it looks well
doc:
http://www.postgresql.org/docs/9.4/static/sql-expressions.html#SQL-SYNTAX-ARRAY-CONSTRUCTORS
it should be fixed too
Regards
Pavel
2014-10-24 10:24 GMT+02:00 Ali Akbar :
> Updated patch attached.
>
> 2014-10-22 20:51 GMT+07:00 Pavel Stehule :
>
>> I agree with you
Updated patch attached.
2014-10-22 20:51 GMT+07:00 Pavel Stehule :
> I agree with your proposal. I have a few comments to design:
>
> 1. patch doesn't hold documentation and regress tests, please append
> it.
>
i've added some regression tests in arrays.sql and a
2014-10-23 4:00 GMT+02:00 Ali Akbar :
> 2014-10-22 22:48 GMT+07:00 Pavel Stehule :
>
>> 2014-10-22 16:58 GMT+02:00 Ali Akbar :
>>
>>> Thanks for the review
>>>
>>> 2014-10-22 20:51 GMT+07:00 Pavel Stehule :
>>>
I agree with your proposal. I have a few comments to design:
>>>
1. patc
2014-10-22 22:48 GMT+07:00 Pavel Stehule :
> 2014-10-22 16:58 GMT+02:00 Ali Akbar :
>
>> Thanks for the review
>>
>> 2014-10-22 20:51 GMT+07:00 Pavel Stehule :
>>
>>> I agree with your proposal. I have a few comments to design:
>>>
>>
>>> 1. patch doesn't hold documentation and regress tests, plea
2014-10-22 16:58 GMT+02:00 Ali Akbar :
> Thanks for the review
>
> 2014-10-22 20:51 GMT+07:00 Pavel Stehule :
>
>> I agree with your proposal. I have a few comments to design:
>>
>
>> 1. patch doesn't hold documentation and regress tests, please append it.
>>
> OK, i'll add the documentation and r
Thanks for the review
2014-10-22 20:51 GMT+07:00 Pavel Stehule :
> I agree with your proposal. I have a few comments to design:
>
> 1. patch doesn't hold documentation and regress tests, please append it.
>
OK, i'll add the documentation and regression test
> 2. this functionality (multidimens
Hi
2014-10-19 8:02 GMT+02:00 Ali Akbar :
> So, is there any idea how we will handle NULL and empty array in
>> array_agg(anyarray)?
>> I propose we just reject those input because the output will make no
>> sense:
>> - array_agg(NULL::int[]) --> the result will be indistinguished from
>> array_ag
>
> So, is there any idea how we will handle NULL and empty array in
> array_agg(anyarray)?
> I propose we just reject those input because the output will make no sense:
> - array_agg(NULL::int[]) --> the result will be indistinguished from
> array_agg of NULL ints.
> - array_agg('{}'::int[]) --> h
2014-10-12 19:37 GMT+07:00 Ali Akbar :
> Currently, it cannot handle NULL arrays:
> backend> select array_agg(a) from (values(null::int[])) a(a);
> 1: array_agg(typeid = 1007, len = -1, typmod = -1, byval = f)
>
> ERROR: cannot aggregate null arrays
>
While thinking about the f
2014-10-11 22:28 GMT+07:00 Tom Lane :
> Seems dangerous as heck; certainly it would have side-effects far more
> wide-ranging than just making this particular function work.
>
> A safer answer is to split array_agg into two functions,
> array_agg(anynonarray) -> anyarray
> array_ag
Ali Akbar writes:
> So, can't we just set the typarray of array types to its self oid?
Seems dangerous as heck; certainly it would have side-effects far more
wide-ranging than just making this particular function work.
A safer answer is to split array_agg into two functions,
array_agg(an
Greetings,
While looking for easier items in PostgreSQL Wiki's Todo List (this will be
my 3rd patch), i found this TODO:
Add a built-in array_agg(anyarray) or similar, that can aggregate
> 1-dimensional arrays into a 2-dimensional array.
>
I've stumbled by this lack of array_agg(anyarray) someti
40 matches
Mail list logo
