Re: [HACKERS] First version of multi-key index support for GiST

2001-05-31 Thread Tom Lane
Oleg Bartunov <[EMAIL PROTECTED]> writes: > We have implemented multi-key index support for GiST. Patch is available > from >http://www.sai.msu.su/~megera/postgres/gist/code/7.1.2/patch_multikeygist.7.1.2.gz I have committed these changes, along with your leak patch of 5/30. > 1. initdb is req

Re: [HACKERS] First version of multi-key index support for GiST

2001-05-31 Thread Tom Lane
Teodor Sigaev <[EMAIL PROTECTED]> writes: > The point was that in gist_tuple_replacekey (called from > gistPageAddItem) key may be replaced by null value, but flag > itup->t_info & INDEX_NULL_MASK is not set. Ah. That's certainly a bug. regards, tom lane -

Re: [HACKERS] First version of multi-key index support for GiST

2001-05-31 Thread Teodor Sigaev
> What is the point of the macro > > #define ATTGET(itup, Rel, i, isnull ) ((char*)( \ > ( IndexTupleSize(itup) == sizeof(IndexTupleData) ) ? \ > *(isnull)=true, NULL \ > : \ > index_getattr(itup, i, (Rel)->r

Re: [HACKERS] First version of multi-key index support for GiST

2001-05-30 Thread Tom Lane
Oleg Bartunov <[EMAIL PROTECTED]> writes: > We have implemented multi-key index support for GiST. Patch is available > from >http://www.sai.msu.su/~megera/postgres/gist/code/7.1.2/patch_multikeygist.7.1.2.gz What is the point of the macro #define ATTGET(itup, Rel, i, isnull ) ((char*)( \