Re: Extensions, patch v20 (bitrot fixes) (was: [HACKERS] Extensions, patch v19 (encoding brainfart fix))

2010-12-18 Thread Robert Haas
On Sat, Dec 18, 2010 at 10:04 PM, Robert Haas wrote: > - Has the issue of changing custom_variable_classes from PGC_SIGHUP to > PGC_SUSET been discussed?  I am not sure whether that's an OK thing to > do.  If it is OK, then the documentation also needs updating. > > - This comment looks like lefto

Re: Extensions, patch v20 (bitrot fixes) (was: [HACKERS] Extensions, patch v19 (encoding brainfart fix))

2010-12-18 Thread David E. Wheeler
On Dec 18, 2010, at 7:04 PM, Robert Haas wrote: > - Did we decide to ditch the encoding parameter for extension scripts > and mandate UTF-8? +1 It was certainly suggested. I think it's a good idea, at least with a first cut. Best, David -- Sent via pgsql-hackers mailing list (pgsql-hackers@p

Re: Extensions, patch v20 (bitrot fixes) (was: [HACKERS] Extensions, patch v19 (encoding brainfart fix))

2010-12-18 Thread Robert Haas
On Sat, Dec 18, 2010 at 2:39 PM, Dimitri Fontaine wrote: > Here it is, attached. The problem was of course due to git branches and > missing local pulling and merging. Going gradually from 7 to 2 branches > causes that, sometimes. I spent a little time looking at this tonight. I'm going to give

Re: [HACKERS] Extensions, patch v19 (encoding brainfart fix)

2010-12-18 Thread Dimitri Fontaine
Itagaki Takahiro writes: > You probably compared wrong versions of source trees. The patch contains > many diffs not related to EXTENSION. It cannot be applied cleanly. Ouch, sorry about that, will revise soon'ish. Meanwhile the git repo is still available here: http://git.postgresql.org/git