Re: [HACKERS] Extensions, patch 22 (cleanup, review, cleanup)

2010-12-21 Thread Dimitri Fontaine
"Erik Rijkers" writes: >> http://pgsql.tapoueh.org/extensions/doc/html/sql-alterextension.html [...] > Two changes to sql-alterextension.sgml: Fixed and uploaded on the URL above, will be in the next patch revision, thanks! Regards, -- Dimitri Fontaine http://2ndQuadrant.fr PostgreSQL : E

Re: [HACKERS] Extensions, patch 22 (cleanup, review, cleanup)

2010-12-21 Thread Erik Rijkers
On Tue, December 21, 2010 09:57, Dimitri Fontaine wrote: > "Erik Rijkers" writes: >> I might be mistaken but it looks like a >> doc/src/sgml/ref/alter_extension.sgml is missing? > > Mmm, it seems that git was agreeing with you, so here's it: > > git ls-files doc/src/sgml/ref/alter_extension.sgm

Re: [HACKERS] Extensions, patch 22 (cleanup, review, cleanup)

2010-12-21 Thread Dimitri Fontaine
Alvaro Herrera writes: > function linkend="functions-extension">pg_extension_flag_dump [...] > So presumably this shouldn't be documented because it cannot be called > anyway? It can be called but only from an extension's script. > To be honest I don't understand the purpose of this part o

Re: [HACKERS] Extensions, patch 22 (cleanup, review, cleanup)

2010-12-21 Thread Dimitri Fontaine
"Erik Rijkers" writes: > I might be mistaken but it looks like a doc/src/sgml/ref/alter_extension.sgml > is missing? Mmm, it seems that git was agreeing with you, so here's it: git ls-files doc/src/sgml/ref/alter_extension.sgml http://git.postgresql.org/gitweb?p=postgresql-extension.git;a

Re: [HACKERS] Extensions, patch 22 (cleanup, review, cleanup)

2010-12-20 Thread Erik Rijkers
>> On Mon, December 20, 2010 22:35, Dimitri Fontaine wrote: > > I might be mistaken but it looks like a doc/src/sgml/ref/alter_extension.sgml is missing? -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailp

Re: [HACKERS] Extensions, patch 22 (cleanup, review, cleanup)

2010-12-20 Thread Alvaro Herrera
Excerpts from Dimitri Fontaine's message of lun dic 20 18:35:44 -0300 2010: > Hi, > > From last round of review from Robert and Álvaro, here's the patch > version 22. Changes: I noticed this bit in the docs: The admin function pg_extension_flag_dump can be used to revert the defau

Re: [HACKERS] Extensions, patch 22 (cleanup, review, cleanup)

2010-12-20 Thread Erik Rijkers
On Mon, December 20, 2010 22:55, Erik Rijkers wrote: > On Mon, December 20, 2010 22:35, Dimitri Fontaine wrote: > > During configure I spotted this: > > [...] > checking for bison... /usr/bin/bison > configure: using bison (GNU Bison) 2.3 > gawk: { if ($4 < 1.875-extension) exit 0; else exit 1;}

Re: [HACKERS] Extensions, patch 22 (cleanup, review, cleanup)

2010-12-20 Thread Erik Rijkers
On Mon, December 20, 2010 22:35, Dimitri Fontaine wrote: > Hi, > > From last round of review from Robert and �lvaro, here's the patch > version 22. Changes: > > - cleanup contrib/ and 'Adjust search_path' comments > - remove contrib/*/uninstall* scripts > - add some documentation to the NO USER