Fabien,
>> Find attached a patch which adds these changes to your current
>> version.
>
> Thank you for the review and patch. Looks good. I changed the status
> to "Ready for Committer". I will wait for a fewd days and if there's
> no objection, I will commit the patch.
I have committed the patc
Fabien,
> Hello Tatsuo-san,
>
>> Thanks for the review. I have registered it to Aug Commit fest.
>> https://commitfest.postgresql.org/action/patch_view?id=1532
>>
>>> I'm not sure of the variable name "is_non_init_parameter_set". I would
>>> suggest "benchmarking_option_set"?
>>
>> Ok, I will rep
Hello Tatsuo-san,
Thanks for the review. I have registered it to Aug Commit fest.
https://commitfest.postgresql.org/action/patch_view?id=1532
I'm not sure of the variable name "is_non_init_parameter_set". I would
suggest "benchmarking_option_set"?
Ok, I will replace the variable name as you
Fabien,
> I have not tested, but the patch looks ok in principle.
Thanks for the review. I have registered it to Aug Commit fest.
https://commitfest.postgresql.org/action/patch_view?id=1532
> I'm not sure of the variable name "is_non_init_parameter_set". I would
> suggest "benchmarking_option_s
Included is the patch to enhance the behavior of pgbench in this regard
IMO. Here is a sample session after patching:
$ ./pgbench -c 10 -T 300 -S -i test
some parameters cannot be used in initialize mode
I have not tested, but the patch looks ok in principle.
I'm not sure of the variable na
Hi,
It is pretty annoying that pgbench does not check parameter which
should not be used with -i. I often type like:
pgbench -c 10 -T 300 -S -i test
and accidentally initialize pgbench database. This is pretty
uncomfortable if the database is huge since initializing huge database
takes long time
