On Thu, Nov 29, 2012 at 3:03 PM, Tom Lane wrote:
> Alvaro Herrera writes:
>> The other interesting question remaining is what to do about the rm_desc
>> function in rmgr.c. We're split between these two ideas:
>
> Why try to link rmgr.c into frontend versions at all? Just make
> a new table fil
On 2012-11-29 15:03:48 -0500, Tom Lane wrote:
> Alvaro Herrera writes:
> > The other interesting question remaining is what to do about the rm_desc
> > function in rmgr.c. We're split between these two ideas:
>
> Why try to link rmgr.c into frontend versions at all? Just make
> a new table file
Alvaro Herrera writes:
> The other interesting question remaining is what to do about the rm_desc
> function in rmgr.c. We're split between these two ideas:
Why try to link rmgr.c into frontend versions at all? Just make
a new table file that only includes the desc function pointers.
Yeah, then
On Wednesday, November 28, 2012 7:07 PM Andres Freund wrote:
> On 2012-11-28 18:58:45 +0530, Amit Kapila wrote:
> > On Wednesday, November 28, 2012 12:17 AM Alvaro Herrera wrote:
> > > I mentioned the remaining issues in a previous email (see message-id
> > > 20121025161751.ge6...@alvh.no-ip.org).
On 2012-11-28 18:58:45 +0530, Amit Kapila wrote:
> On Wednesday, November 28, 2012 12:17 AM Alvaro Herrera wrote:
> > I mentioned the remaining issues in a previous email (see message-id
> > 20121025161751.ge6...@alvh.no-ip.org). Attached is a patch that enables
> > xlogdump to #include xlog_inter
On Wednesday, November 28, 2012 12:17 AM Alvaro Herrera wrote:
> I mentioned the remaining issues in a previous email (see message-id
> 20121025161751.ge6...@alvh.no-ip.org). Attached is a patch that enables
> xlogdump to #include xlog_internal.h by way of removing that file's
> inclusion of fmgr.
I mentioned the remaining issues in a previous email (see
message-id 20121025161751.ge6...@alvh.no-ip.org). Attached is a
patch that enables xlogdump to #include xlog_internal.h by way of
removing that file's inclusion of fmgr.h, which is problematic. I don't
think this should be too contentious.
