Re: [HACKERS] Eliminating pg_catalog.pg_rewrite.ev_attr

2013-09-05 Thread Kevin Grittner
Kevin Grittner wrote: > New patch attached. Pushed (to master only). 277607d600fb71e25082b94302ca1716403cd0bc -- Kevin Grittner EDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to yo

Re: [HACKERS] Eliminating pg_catalog.pg_rewrite.ev_attr

2013-09-04 Thread Kevin Grittner
Tom Lane wrote: > Shouldn't attribute_used() be removed from rewriteManip.h? Yeah, I don't know how I missed that.  Thanks. > I was a bit surprised by your removal of the > rangeTableEntry_used() test in the hunk at > rewriteHandler.c:1273ff.  That's probably all right, but it takes > this out

Re: [HACKERS] Eliminating pg_catalog.pg_rewrite.ev_attr

2013-09-04 Thread Tom Lane
Kevin Grittner writes: > Unless someone has an objection or thinks this needs to go through > the CF process, I will commit it tomorrow, with a catversion bump. Shouldn't attribute_used() be removed from rewriteManip.h? I was a bit surprised by your removal of the rangeTableEntry_used() test in

[HACKERS] Eliminating pg_catalog.pg_rewrite.ev_attr

2013-09-04 Thread Kevin Grittner
This was previously discussed here: http://www.postgresql.org/message-id/flat/24836.1370713...@sss.pgh.pa.us#24836.1370713...@sss.pgh.pa.us The attached patch implements what I think we agreed on. To recap, ev_attr was present in pg_rewrite at the point that Postgres95 version 1.01 source code w

Re: [HACKERS] Eliminating pg_catalog.pg_rewrite.ev_attr

2013-09-04 Thread Alvaro Herrera
Is this transformation correct? If I read this correctly, you're missing the rangeTableEntry_used() condition, no? > *** a/src/backend/rewrite/rewriteHandler.c > --- b/src/backend/rewrite/rewriteHandler.c > *** > *** 1273,1287 matchLocks(CmdType event, > }