Re: [HACKERS] Duplicate node tag assignments

2016-12-28 Thread Alvaro Herrera
Amit Kapila wrote: > On Wed, Dec 28, 2016 at 10:03 PM, Tom Lane wrote: > > Or we could just abandon the manually-assigned breaks in the list > > altogether, and let NodeTags run from 1 to whatever. This would > > slightly complicate debugging, in that the numeric values of node > > tags would ch

Re: [HACKERS] Duplicate node tag assignments

2016-12-28 Thread Amit Kapila
On Wed, Dec 28, 2016 at 10:03 PM, Tom Lane wrote: > By chance I happened to notice that the recent partition patch pushed > us over the number of available node tags between > > T_A_Expr = 900, > > and > > T_TriggerData = 950,/* in commands/trigger.h */ > > Specifically

Re: [HACKERS] Duplicate node tag assignments

2016-12-28 Thread Tom Lane
Andres Freund writes: > On 2016-12-28 11:33:31 -0500, Tom Lane wrote: >> By chance I happened to notice that the recent partition patch pushed >> us over the number of available node tags between >> So I'm leaning to the second, more drastic, solution. Thoughts? > Alternatively we could add a -W

Re: [HACKERS] Duplicate node tag assignments

2016-12-28 Thread Andres Freund
Hi, On 2016-12-28 11:33:31 -0500, Tom Lane wrote: > By chance I happened to notice that the recent partition patch pushed > us over the number of available node tags between > > T_A_Expr = 900, > So I'm leaning to the second, more drastic, solution. Thoughts? Alternatively we could add a

[HACKERS] Duplicate node tag assignments

2016-12-28 Thread Tom Lane
By chance I happened to notice that the recent partition patch pushed us over the number of available node tags between T_A_Expr = 900, and T_TriggerData = 950,/* in commands/trigger.h */ Specifically we now have some of the replication grammar node type codes confli