Re: [HACKERS] Dry-run mode for pg_archivecleanup

2012-02-06 Thread Gabriele Bartolini
Ciao Alvaro, Il 06/02/12 16:02, Alvaro Herrera ha scritto: FWIW I committed this last week, though I changed the debug message wording slightly -- hope that's OK; it can be adjusted of course. http://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=b2e431a4db81a735d1474c4d1565a20b8358

Re: [HACKERS] Dry-run mode for pg_archivecleanup

2012-02-06 Thread Alvaro Herrera
Excerpts from Gabriele Bartolini's message of mar ene 31 12:29:51 -0300 2012: > Hi Robert, > > sorry for the delay. > > Il 27/01/12 15:47, Robert Haas ha scritto: > > This email thread seems to have trailed off without reaching a > > conclusion. The patch is marked as Waiting on Author in the C

Re: [HACKERS] Dry-run mode for pg_archivecleanup

2012-02-01 Thread Josh Kupershmidt
On Tue, Jan 31, 2012 at 10:29 AM, Gabriele Bartolini wrote: > Here is my final version which embeds comments from Josh. I have also added > debug information to be printed in case '-d' is given. Looks fine; will mark Ready For Committer. Josh -- Sent via pgsql-hackers mailing list (pgsql-hack

Re: [HACKERS] Dry-run mode for pg_archivecleanup

2012-01-31 Thread Alvaro Herrera
Excerpts from Gabriele Bartolini's message of mar ene 31 12:31:58 -0300 2012: > Hi Alvaro, > > Il 27/01/12 23:55, Alvaro Herrera ha scritto: > > If you do that, please make sure you use two complete separate strings > > instead of building one from spare parts. This bit is missing the _() > > s

Re: [HACKERS] Dry-run mode for pg_archivecleanup

2012-01-31 Thread Gabriele Bartolini
Hi Alvaro, Il 27/01/12 23:55, Alvaro Herrera ha scritto: If you do that, please make sure you use two complete separate strings instead of building one from spare parts. This bit is missing the _() stuff though. Currently pg_archivecleanup does not comply with localisation standards. I can pu

Re: [HACKERS] Dry-run mode for pg_archivecleanup

2012-01-31 Thread Gabriele Bartolini
Hi Robert, sorry for the delay. Il 27/01/12 15:47, Robert Haas ha scritto: This email thread seems to have trailed off without reaching a conclusion. The patch is marked as Waiting on Author in the CommitFest application, but I'm not sure that's accurate. Can we try to nail this down? Here i

Re: [HACKERS] Dry-run mode for pg_archivecleanup

2012-01-27 Thread Alvaro Herrera
Excerpts from Josh Kupershmidt's message of vie ene 27 19:43:51 -0300 2012: > On Fri, Jan 27, 2012 at 9:47 AM, Robert Haas wrote: > > This email thread seems to have trailed off without reaching a > > conclusion.  The patch is marked as Waiting on Author in the > > CommitFest application, but I'

Re: [HACKERS] Dry-run mode for pg_archivecleanup

2012-01-27 Thread Josh Kupershmidt
On Fri, Jan 27, 2012 at 9:47 AM, Robert Haas wrote: > On Sun, Jan 15, 2012 at 5:05 PM, Josh Kupershmidt wrote: >> On Sun, Jan 15, 2012 at 3:02 PM, Gabriele Bartolini >> wrote: >> >>> My actual intention was to have the filename as output of the command, in >>> order to easily "pipe" it to anothe

Re: [HACKERS] Dry-run mode for pg_archivecleanup

2012-01-27 Thread Robert Haas
On Sun, Jan 15, 2012 at 5:05 PM, Josh Kupershmidt wrote: > On Sun, Jan 15, 2012 at 3:02 PM, Gabriele Bartolini > wrote: > >> My actual intention was to have the filename as output of the command, in >> order to easily "pipe" it to another script. Hence my first choice was to >> use the stdout cha

Re: [HACKERS] Dry-run mode for pg_archivecleanup

2012-01-15 Thread Josh Kupershmidt
On Sun, Jan 15, 2012 at 3:02 PM, Gabriele Bartolini wrote: > My actual intention was to have the filename as output of the command, in > order to easily "pipe" it to another script. Hence my first choice was to > use the stdout channel, considering also that pg_archivecleanup in dry-run > mode is

Re: [HACKERS] Dry-run mode for pg_archivecleanup

2012-01-15 Thread Gabriele Bartolini
Hi Josh, Il 15/01/12 01:13, Josh Kupershmidt ha scritto: I have signed on to review this patch for the 2012-01 CF. The patch applies cleanly, includes the necessary documentation, and implements a useful feature. Thank you for dedicating your time to this matter. I think the actual debugging l

Re: [HACKERS] Dry-run mode for pg_archivecleanup

2012-01-14 Thread Josh Kupershmidt
On Sun, Dec 11, 2011 at 9:52 AM, Gabriele Bartolini wrote: > Hi guys, > >  I have added the '-n' option to pg_archivecleanup which performs a dry-run > and outputs the names of the files to be removed to stdout (making possible > to pass the list via pipe to another process). > >  Please find atta

Re: [HACKERS] Dry-run mode for pg_archivecleanup

2011-12-11 Thread Magnus Hagander
On Sun, Dec 11, 2011 at 15:52, Gabriele Bartolini wrote: > Hi guys, > >  I have added the '-n' option to pg_archivecleanup which performs a dry-run > and outputs the names of the files to be removed to stdout (making possible > to pass the list via pipe to another process). > >  Please find attach

[HACKERS] Dry-run mode for pg_archivecleanup

2011-12-11 Thread Gabriele Bartolini
Hi guys, I have added the '-n' option to pg_archivecleanup which performs a dry-run and outputs the names of the files to be removed to stdout (making possible to pass the list via pipe to another process). Please find attached the small patch. I submit it to the CommitFest. Thanks, Gabr

Re: [HACKERS] Dry Run mode for pg_archivecleanup

2011-06-29 Thread Fujii Masao
On Tue, Jun 28, 2011 at 6:33 AM, Gabriele Bartolini wrote: >   I have added the '-n' option to pg_archivecleanup which performs a dry-run > and outputs the names of the files to be removed to stdout (making possible > to pass the list via pipe to another process). Please find attached the > small

[HACKERS] Dry Run mode for pg_archivecleanup

2011-06-27 Thread Gabriele Bartolini
Hi guys, I have added the '-n' option to pg_archivecleanup which performs a dry-run and outputs the names of the files to be removed to stdout (making possible to pass the list via pipe to another process). Please find attached the small patch. Thanks, Gabriele -- Gabriele Bartolini - 2