Re: [HACKERS] Debug message in RemoveOldXlogFiles

2010-06-18 Thread Tom Lane
Simon Riggs writes: > I think it would be more helpful if it showed a filename. Shall we > change that? The point of the committed change was to make that message look like every other one in xlog.c that shows a log/seg pair. If we were going to start redesigning the printout format, I'd persona

Re: [HACKERS] Debug message in RemoveOldXlogFiles

2010-06-18 Thread Simon Riggs
On Thu, 2010-06-17 at 16:13 +0900, Fujii Masao wrote: > Hi, > > In the following debug message in RemoveOldXlogFiles(), the variables > "log" and "seg" don't indicate LSN, so we should use %u instead of %X? > > elog(DEBUG2, "removing WAL segments older than %X/%X", log, seg); > > I attached

Re: [HACKERS] Debug message in RemoveOldXlogFiles

2010-06-17 Thread Tom Lane
Fujii Masao writes: > In the following debug message in RemoveOldXlogFiles(), the variables > "log" and "seg" don't indicate LSN, so we should use %u instead of %X? > elog(DEBUG2, "removing WAL segments older than %X/%X", log, seg); > I attached the patch to do so. Applied, thanks.

[HACKERS] Debug message in RemoveOldXlogFiles

2010-06-17 Thread Fujii Masao
Hi, In the following debug message in RemoveOldXlogFiles(), the variables "log" and "seg" don't indicate LSN, so we should use %u instead of %X? elog(DEBUG2, "removing WAL segments older than %X/%X", log, seg); I attached the patch to do so. Regards, -- Fujii Masao NIPPON TELEGRAPH AND TE