Re: [HACKERS] Credit in the release notes WAS: Draft release notes complete

2012-05-12 Thread Josh Berkus
>> I haven't yet heard any very good argument for deviating from our >> past practice, which is to credit just the principal author(s) >> of each patch, not reviewers. > > Is that what people want? Reviewers are easily removed. What about > committers who adjust the patch? Well, I still think

Re: [HACKERS] Credit in the release notes WAS: Draft release notes complete

2012-05-12 Thread Robert Haas
On Sat, May 12, 2012 at 10:35 PM, Bruce Momjian wrote: >> I haven't yet heard any very good argument for deviating from our >> past practice, which is to credit just the principal author(s) >> of each patch, not reviewers. > > Is that what people want?  Reviewers are easily removed. +1 from me.

Re: [HACKERS] Credit in the release notes WAS: Draft release notes complete

2012-05-12 Thread Bruce Momjian
On Sat, May 12, 2012 at 09:59:12PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > On Sat, May 12, 2012 at 09:27:21PM -0400, Andrew Dunstan wrote: > >> We seem to be in danger of overthinking this. > > > Results have just shown it isn't a simple case. It is unclear how > > important the revie

Re: [HACKERS] Credit in the release notes WAS: Draft release notes complete

2012-05-12 Thread Tom Lane
Bruce Momjian writes: > On Sat, May 12, 2012 at 09:27:21PM -0400, Andrew Dunstan wrote: >> We seem to be in danger of overthinking this. > Results have just shown it isn't a simple case. It is unclear how > important the reviewers were, and how much a committer rewrote the > patch, and the signi

Re: [HACKERS] Credit in the release notes WAS: Draft release notes complete

2012-05-12 Thread Bruce Momjian
On Sat, May 12, 2012 at 09:27:21PM -0400, Andrew Dunstan wrote: > >Should we go with a single developer per item, and then let people > >suggest corrections? With reviewers involved, and often multiple commit > >messages per release note item, the just isn't enough detail in git logs > >to reprodu

Re: [HACKERS] Credit in the release notes WAS: Draft release notes complete

2012-05-12 Thread Andrew Dunstan
On 05/12/2012 09:02 PM, Bruce Momjian wrote: On Sat, May 12, 2012 at 03:42:48PM -0700, Josh Berkus wrote: How many names on a single item is ideal? The activity of reviewers and their names on commit messages has greatly expanded the number of potential names per item. How much of a downside

Re: [HACKERS] Credit in the release notes WAS: Draft release notes complete

2012-05-12 Thread Bruce Momjian
On Sat, May 12, 2012 at 03:42:48PM -0700, Josh Berkus wrote: > > > How many names on a single item is ideal? The activity of reviewers and > > their names on commit messages has greatly expanded the number of > > potential names per item. > > > > How much of a downside is having the names in the

Re: [HACKERS] Credit in the release notes WAS: Draft release notes complete

2012-05-12 Thread Josh Berkus
> How many names on a single item is ideal? The activity of reviewers and > their names on commit messages has greatly expanded the number of > potential names per item. > > How much of a downside is having the names in the release notes? For > example, we decided that company names shouldn't b