Re: [HACKERS] Core dump running PL/Perl installcheck with bleadperl [PATCH]

2010-03-09 Thread Tom Lane
Tim Bunce writes: > The attached patch fixes the problem by changing the SvTYPE check to use > SvROK instead. Although I only tripped over one case, the patch changes > all four uses of SvTYPE(sv) == SVt_RV. The remaining uses of SvTYPE are ok. Applied back to 8.0. 7.4 seems not to contain any t

Re: [HACKERS] Core dump running PL/Perl installcheck with bleadperl [PATCH]

2010-03-08 Thread Tim Bunce
On Sun, Mar 07, 2010 at 12:11:26PM -0500, Tom Lane wrote: > Tim Bunce writes: > > I encountered a core dump running PL/Perl installcheck with a very > > recent git HEAD of PostgreSQL and a not quite so recent git HEAD of perl. > > > The cause is a subtle difference between SvTYPE(sv) == SVt_RV an

Re: [HACKERS] Core dump running PL/Perl installcheck with bleadperl [PATCH]

2010-03-07 Thread Tom Lane
Tim Bunce writes: > I encountered a core dump running PL/Perl installcheck with a very > recent git HEAD of PostgreSQL and a not quite so recent git HEAD of perl. > The cause is a subtle difference between SvTYPE(sv) == SVt_RV and > SvROK(sv). The former is checking a low-level implementation det

[HACKERS] Core dump running PL/Perl installcheck with bleadperl [PATCH]

2010-03-05 Thread Tim Bunce
I encountered a core dump running PL/Perl installcheck with a very recent git HEAD of PostgreSQL and a not quite so recent git HEAD of perl. The cause is a subtle difference between SvTYPE(sv) == SVt_RV and SvROK(sv). The former is checking a low-level implementation detail while the later is dire