Re: [HACKERS] Confusing docs about GetForeignUpperPaths in fdwhandler.sgml

2016-11-03 Thread Etsuro Fujita
On 2016/11/03 23:39, Robert Haas wrote: On Wed, Oct 26, 2016 at 3:18 PM, Tom Lane wrote: A larger issue is that I think the API itself is poorly designed, as I stated awhile ago (<31706.1457547...@sss.pgh.pa.us>) I agree on that point. I plan to rewrite direct modify using upper planner pat

Re: [HACKERS] Confusing docs about GetForeignUpperPaths in fdwhandler.sgml

2016-11-03 Thread Robert Haas
On Wed, Oct 26, 2016 at 3:18 PM, Tom Lane wrote: > Robert Haas writes: >> I'm not interested in committing this patch. I don't believe it is an >> improvement on what we've got today. >> Tom, any chance you could offer an opinion? > > I have no objection to this patch as such, but I think that t

Re: [HACKERS] Confusing docs about GetForeignUpperPaths in fdwhandler.sgml

2016-10-26 Thread Tom Lane
Robert Haas writes: > I'm not interested in committing this patch. I don't believe it is an > improvement on what we've got today. > Tom, any chance you could offer an opinion? I have no objection to this patch as such, but I think that the docs around FDW direct modify need significantly more w

Re: [HACKERS] Confusing docs about GetForeignUpperPaths in fdwhandler.sgml

2016-10-26 Thread Robert Haas
On Sun, Oct 2, 2016 at 10:03 AM, Michael Paquier wrote: > On Thu, Sep 22, 2016 at 7:48 PM, Rushabh Lathia > wrote: >> I performed basic test with patch, >> >> a) patch get applied cleanly on latest source, >> b) able to build documentation cleanly. >> >> Marking this as ready for committer. > > O

Re: [HACKERS] Confusing docs about GetForeignUpperPaths in fdwhandler.sgml

2016-10-02 Thread Michael Paquier
On Thu, Sep 22, 2016 at 7:48 PM, Rushabh Lathia wrote: > I performed basic test with patch, > > a) patch get applied cleanly on latest source, > b) able to build documentation cleanly. > > Marking this as ready for committer. Oops, incorrect patch... I am moving it to next CF. Discussion can cont

Re: [HACKERS] Confusing docs about GetForeignUpperPaths in fdwhandler.sgml

2016-09-22 Thread Rushabh Lathia
On Fri, Sep 2, 2016 at 5:00 PM, Etsuro Fujita wrote: > Hi Robert, > > Thanks for the comments! > > On 2016/09/02 11:55, Robert Haas wrote: > >> On Mon, Aug 1, 2016 at 5:44 PM, Etsuro Fujita >> wrote: >> >>> I noticed that the following note about direct modification via >>> GetForeignUpperPaths

Re: [HACKERS] Confusing docs about GetForeignUpperPaths in fdwhandler.sgml

2016-09-02 Thread Etsuro Fujita
Hi Robert, Thanks for the comments! On 2016/09/02 11:55, Robert Haas wrote: On Mon, Aug 1, 2016 at 5:44 PM, Etsuro Fujita wrote: I noticed that the following note about direct modification via GetForeignUpperPaths in fdwhandler.sgml is a bit confusing. We have another approach using PlanDire

Re: [HACKERS] Confusing docs about GetForeignUpperPaths in fdwhandler.sgml

2016-09-01 Thread Robert Haas
On Mon, Aug 1, 2016 at 5:44 PM, Etsuro Fujita wrote: > I noticed that the following note about direct modification via > GetForeignUpperPaths in fdwhandler.sgml is a bit confusing. We have another > approach using PlanDirectModify, so that should be reflected in the note as > well. Please find a

Re: [HACKERS] Confusing docs about GetForeignUpperPaths in fdwhandler.sgml

2016-08-31 Thread Etsuro Fujita
On 2016/08/01 21:14, Etsuro Fujita wrote: I noticed that the following note about direct modification via GetForeignUpperPaths in fdwhandler.sgml is a bit confusing. We have another approach using PlanDirectModify, so that should be reflected in the note as well. Please find attached a patch.

[HACKERS] Confusing docs about GetForeignUpperPaths in fdwhandler.sgml

2016-08-01 Thread Etsuro Fujita
Hi, I noticed that the following note about direct modification via GetForeignUpperPaths in fdwhandler.sgml is a bit confusing. We have another approach using PlanDirectModify, so that should be reflected in the note as well. Please find attached a patch. PlanForeignModify and the