Re: [HACKERS] Confusing comment in tidbitmap.c

2014-12-14 Thread Tom Lane
David Rowley writes: > The following comment above #define PAGES_PER_CHUNK in tibbitmap.c appears > to be incorrect: > "But we > * also want PAGES_PER_CHUNK to be a power of 2 to avoid expensive integer > * remainder operations. So, define it like this:" > I don't quite follow this as it does

[HACKERS] Confusing comment in tidbitmap.c

2014-12-14 Thread David Rowley
The following comment above #define PAGES_PER_CHUNK in tibbitmap.c appears to be incorrect: "But we * also want PAGES_PER_CHUNK to be a power of 2 to avoid expensive integer * remainder operations. So, define it like this:" I don't quite follow this as it does nothing of the kind. Check tbm_pa