Re: [HACKERS] Compiler warning in ecpglib/execute.c

2009-02-04 Thread Michael Meskes
On Tue, Feb 03, 2009 at 04:06:39PM -0300, Alvaro Herrera wrote: > Note that spoonbill is still red. This animal is special because it > uses some peculiar malloc flags. Not just spoonbill, five of them are. Without access to a failing machine this is difficult to debug. I found some missing error

Re: [HACKERS] Compiler warning in ecpglib/execute.c

2009-02-03 Thread Alvaro Herrera
Michael Meskes wrote: > On Mon, Feb 02, 2009 at 02:56:18PM -0500, Tom Lane wrote: > > CVS HEAD is producing > > ... > > Thanks for the note, I missed this copy&paste error of mine. Fixed in HEAD. > This should alos make the buildfarm green again. Note that spoonbill is still red. This animal is

Re: [HACKERS] Compiler warning in ecpglib/execute.c

2009-02-03 Thread Michael Meskes
On Mon, Feb 02, 2009 at 02:56:18PM -0500, Tom Lane wrote: > CVS HEAD is producing > ... Thanks for the note, I missed this copy&paste error of mine. Fixed in HEAD. This should alos make the buildfarm green again. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|C

[HACKERS] Compiler warning in ecpglib/execute.c

2009-02-02 Thread Tom Lane
CVS HEAD is producing execute.c: In function 'ecpg_store_result': execute.c:394: warning: 'act_tuple' may be used uninitialized in this function It looks to me like this is an actual bug, not just the compiler being insufficiently smart to prove the variable is set before use.