Re: [HACKERS] Compile fail, alpha5 & gcc 4.3.3 in elog.c

2010-04-05 Thread Magnus Hagander
On Tue, Apr 6, 2010 at 07:29, Takahiro Itagaki wrote: > > Tom Lane wrote: > >> > -   cygwin_conv_to_full_win32_path(cmdLine, buf); >> > +   cygwin_conv_path(CCP_POSIX_TO_WIN_A, cmdLine, buf, sizeof(buf)); >> >> Buildfarm member brown_bat didn't like this.  Seeing that that's the >> *only* active

Re: [HACKERS] Compile fail, alpha5 & gcc 4.3.3 in elog.c

2010-04-05 Thread Takahiro Itagaki
Tom Lane wrote: > > - cygwin_conv_to_full_win32_path(cmdLine, buf); > > + cygwin_conv_path(CCP_POSIX_TO_WIN_A, cmdLine, buf, sizeof(buf)); > > Buildfarm member brown_bat didn't like this. Seeing that that's the > *only* active cygwin buildfarm member, that's not a good percentage. Hmmm, b

Re: [HACKERS] Compile fail, alpha5 & gcc 4.3.3 in elog.c

2010-04-05 Thread Robert Haas
On Apr 2, 2010, at 6:07 PM, Tom Lane wrote: > Peter Eisentraut writes: >> b) The tag isn't actually version-stamped. configure/configure.in >> still >> say 9.0devel. > > Sure, because the tag is on a branch. According to the commit message > that went by, Robert did that correctly: > > http://

Re: [HACKERS] Compile fail, alpha5 & gcc 4.3.3 in elog.c

2010-04-05 Thread Tom Lane
Peter Eisentraut writes: > b) The tag isn't actually version-stamped. configure/configure.in still > say 9.0devel. Sure, because the tag is on a branch. According to the commit message that went by, Robert did that correctly: http://archives.postgresql.org/pgsql-committers/2010-03/msg00378.php

Re: [HACKERS] Compile fail, alpha5 & gcc 4.3.3 in elog.c

2010-04-05 Thread Peter Eisentraut
On fre, 2010-04-02 at 14:44 -0400, Robert Haas wrote: > On Apr 2, 2010, at 12:34 PM, Kevin Grittner > wrote: > > Josh Berkus wrote: > > > >> Robert, > > > >> do you think you could put up replacement tarballs today? > > > > If you don't hear from him soon, perhaps he's traveling: > > > > http://a

Re: [HACKERS] Compile fail, alpha5 & gcc 4.3.3 in elog.c

2010-04-05 Thread Tom Lane
Takahiro Itagaki writes: > Any objections for the following fix? > - cygwin_conv_to_full_win32_path(cmdLine, buf); > + cygwin_conv_path(CCP_POSIX_TO_WIN_A, cmdLine, buf, sizeof(buf)); Buildfarm member brown_bat didn't like this. Seeing that that's the *only* active cygwin buildfarm membe

Re: [HACKERS] Compile fail, alpha5 & gcc 4.3.3 in elog.c

2010-04-04 Thread Robert Haas
On Fri, Apr 2, 2010 at 2:44 PM, Robert Haas wrote: > On Apr 2, 2010, at 12:34 PM, Kevin Grittner > wrote: >> Josh Berkus wrote: >> >>> Robert, >> >>> do you think you could put up replacement tarballs today? >> >> If you don't hear from him soon, perhaps he's traveling: >> >> http://archives.pos

Re: [HACKERS] Compile fail, alpha5 & gcc 4.3.3 in elog.c

2010-04-02 Thread Robert Haas
On Apr 2, 2010, at 12:34 PM, Kevin Grittner wrote: > Josh Berkus wrote: > >> Robert, > >> do you think you could put up replacement tarballs today? > > If you don't hear from him soon, perhaps he's traveling: > > http://archives.postgresql.org/pgsql-hackers/2010-03/msg01298.php Yeah, sorry, I'm

Re: [HACKERS] Compile fail, alpha5 & gcc 4.3.3 in elog.c

2010-04-02 Thread Kevin Grittner
Josh Berkus wrote: > Robert, > do you think you could put up replacement tarballs today? If you don't hear from him soon, perhaps he's traveling: http://archives.postgresql.org/pgsql-hackers/2010-03/msg01298.php -Kevin -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.or

Re: [HACKERS] Compile fail, alpha5 & gcc 4.3.3 in elog.c

2010-04-02 Thread Josh Berkus
Robert, > I'm obviously very sorry for the hassle and frustration caused by this > mistake, especially to Dave Page, but hopefully you understand that I > was trying rather hard to get this right; and perhaps the Wiki page > can also be improved to mention some of these details. Bound to happen t

Re: [HACKERS] Compile fail, alpha5 & gcc 4.3.3 in elog.c

2010-04-02 Thread GenieJapo
Hi, I use Ubuntu 9.04 (GCC 4.3.3). Build was failed too. I was able to compile with some small correction. All are the one that relates only to the return value of write() and fgets(). (1) src/backend/utils/error/elog.c elog.c: In function 'write_console': elog.c:1698: error: ignoring return v

Re: [HACKERS] Compile fail, alpha5 & gcc 4.3.3 in elog.c

2010-04-02 Thread Peter Eisentraut
On fre, 2010-04-02 at 06:42 -0400, Robert Haas wrote: > Forgive me for being a little annoyed here, but I actually did follow > that document quite closely. Unfortunately it omits to mention a few > key points. Sorry, I had suspected that you didn't do a clean cvs export. It was a frequent proble

Re: [HACKERS] Compile fail, alpha5 & gcc 4.3.3 in elog.c

2010-04-02 Thread Robert Haas
On Apr 2, 2010, at 5:18 AM, Peter Eisentraut wrote: > On fre, 2010-04-02 at 04:48 -0400, Robert Haas wrote: >> I can't easily get on line to check this just now, but did I >> accidentally bundle my Makefile.custom into this tarball? > > Uhum, if you had followed > http://wiki.postgresql.org/wiki/A

Re: [HACKERS] Compile fail, alpha5 & gcc 4.3.3 in elog.c

2010-04-02 Thread Dave Page
On Fri, Apr 2, 2010 at 9:48 AM, Robert Haas wrote:. > > I can't easily get on line to check this just now, but did I > accidentally bundle my Makefile.custom into this tarball? D'oh! That explains the pain I had building the binaries (mainly the add-ons). We assumed that -Werror was an intentiona

Re: [HACKERS] Compile fail, alpha5 & gcc 4.3.3 in elog.c

2010-04-02 Thread Peter Eisentraut
On tor, 2010-04-01 at 23:28 -0700, Josh Berkus wrote: > Fails on: > Ubuntu, gcc 4.3.3 > Ubuntu, gcc 4.4.1 > OSX 10.5, gcc 4.0.1* Ubuntu builds with hardening options by default, which cause several warnings. Not sure about the OSX issue. -- Sent via pgsql-hackers mailing list (pgsql-hackers@

Re: [HACKERS] Compile fail, alpha5 & gcc 4.3.3 in elog.c

2010-04-02 Thread Peter Eisentraut
On fre, 2010-04-02 at 04:48 -0400, Robert Haas wrote: > I can't easily get on line to check this just now, but did I > accidentally bundle my Makefile.custom into this tarball? Uhum, if you had followed http://wiki.postgresql.org/wiki/Alpha_release_process then this couldn't have happened. --

Re: [HACKERS] Compile fail, alpha5 & gcc 4.3.3 in elog.c

2010-04-02 Thread Robert Haas
On Apr 2, 2010, at 2:28 AM, Josh Berkus wrote: > Tom, Robert, etc. > > Ok, this issue seems to be specific to some versions of gcc. Note > that > in testing this nobody enabled any special compile or environment > variables of any kind, so if there's a -Werror where it shouldn't be, > it's in our

Re: [HACKERS] Compile fail, alpha5 & gcc 4.3.3 in elog.c

2010-04-02 Thread Takahiro Itagaki
Josh Berkus wrote: > Ok, this issue seems to be specific to some versions of gcc. Note that > in testing this nobody enabled any special compile or environment > variables of any kind, so if there's a -Werror where it shouldn't be, > it's in our code. Hi, cygwin also has -Werror in default, an

Re: [HACKERS] Compile fail, alpha5 & gcc 4.3.3 in elog.c

2010-04-01 Thread Josh Berkus
Tom, Robert, etc. Ok, this issue seems to be specific to some versions of gcc. Note that in testing this nobody enabled any special compile or environment variables of any kind, so if there's a -Werror where it shouldn't be, it's in our code. Succeeds on: Red Hat, gcc 4.4.3 OSX, gcc 4.2.1 Debian

Re: [HACKERS] Compile fail, alpha5 & gcc 4.3.3 in elog.c

2010-04-01 Thread Josh Berkus
> No, you stuck in -Werror. Don't do that on bleeding-edge gcc (or > bleeding-edge anything). Found it ... Robert, you stuck a -Werror in the gzip file you uploaded (but not, for some reason, the bzip). -- -- Josh Berkus Po

Re: [HACKERS] Compile fail, alpha5 & gcc 4.3.3 in elog.c

2010-04-01 Thread Josh Berkus
On 4/1/10 9:57 PM, Tom Lane wrote: > Josh Berkus writes: >> Hmmm. I appear to have had a compile error with that alpha5 tarball, >> in elog.c. No special options on compile, except an alternate directory >> and port. > > No, you stuck in -Werror. Don't do that on bleeding-edge gcc (or > bleed

Re: [HACKERS] Compile fail, alpha5 & gcc 4.3.3 in elog.c

2010-04-01 Thread Tom Lane
Josh Berkus writes: > Hmmm. I appear to have had a compile error with that alpha5 tarball, > in elog.c. No special options on compile, except an alternate directory > and port. No, you stuck in -Werror. Don't do that on bleeding-edge gcc (or bleeding-edge anything). r

[HACKERS] Compile fail, alpha5 & gcc 4.3.3 in elog.c

2010-04-01 Thread Josh Berkus
Guys, Hmmm. I appear to have had a compile error with that alpha5 tarball, in elog.c. No special options on compile, except an alternate directory and port. Ubunutu 9.10 server GCC 4.3.3 Tries both: ./configure --with-pgport=5490 --prefix=/usr/local/pgsql/9.0/ and: ./configure --with-pgport=54