Re: [HACKERS] Comments on automatic DML routing and explicit partitioning subcommands

2009-07-18 Thread Robert Haas
On Tue, Jul 14, 2009 at 10:14 AM, Alvaro Herrera wrote: >> Thank you very much for the patch. Well done for getting to this stage. >> There is definitely much support for your work. > > Thanks for the thorough review.  Please when you add a comment to the > commitfest app, make sure you specify the

Re: [HACKERS] Comments on automatic DML routing and explicit partitioning subcommands

2009-07-14 Thread Alvaro Herrera
Simon, Simon Riggs escribió: > Kedar, > > Thank you very much for the patch. Well done for getting to this stage. > There is definitely much support for your work. Thanks for the thorough review. Please when you add a comment to the commitfest app, make sure you specify the message-id where y

[HACKERS] Comments on automatic DML routing and explicit partitioning subcommands

2009-07-14 Thread Simon Riggs
(submitting review slightly earlier than start of commitfest) Kedar, Thank you very much for the patch. Well done for getting to this stage. There is definitely much support for your work. My thoughts after initial review are fairly wide ranging. Overall, the patch is not ready/close to commit