Re: [HACKERS] Comments on SQL/Med objects

2011-04-01 Thread Robert Haas
On Fri, Apr 1, 2011 at 9:40 AM, Shigeru HANADA wrote: >  - pg_dump support for comment on fdw and server Applied, good catch, thanks. >  - psql describe commands (\dew+ and \des+) Not sure if we want this behavior change or not. Any other opinions? It doesn't look like there's any particular c

Re: [HACKERS] Comments on SQL/Med objects

2011-04-01 Thread Robert Haas
On Fri, Apr 1, 2011 at 9:40 AM, Shigeru HANADA wrote: > On Thu, 31 Mar 2011 11:24:27 -0400 > Robert Haas wrote: >> Attached.  Foreign tables are already OK, I believe; it's only foreign >> data wrappers and foreign servers that appear to need fixing. > > The patch seems good for basic functionari

Re: [HACKERS] Comments on SQL/Med objects

2011-03-31 Thread Robert Haas
On Mon, Mar 28, 2011 at 12:29 AM, Robert Haas wrote: > On Mon, Mar 28, 2011 at 12:06 AM, Tom Lane wrote: >> Robert Haas writes: >>> On Wed, Mar 23, 2011 at 12:53 PM, Tom Lane wrote: Yeah, I had a private TODO about that.  I'd like to see if we can refactor the grammar to eliminate som

Re: [HACKERS] Comments on SQL/Med objects

2011-03-27 Thread Robert Haas
On Mon, Mar 28, 2011 at 12:06 AM, Tom Lane wrote: > Robert Haas writes: >> On Wed, Mar 23, 2011 at 12:53 PM, Tom Lane wrote: >>> Yeah, I had a private TODO about that.  I'd like to see if we can >>> refactor the grammar to eliminate some of the duplication there >>> as well as the potential for

Re: [HACKERS] Comments on SQL/Med objects

2011-03-27 Thread Tom Lane
Robert Haas writes: > On Wed, Mar 23, 2011 at 12:53 PM, Tom Lane wrote: >> Yeah, I had a private TODO about that.  I'd like to see if we can >> refactor the grammar to eliminate some of the duplication there >> as well as the potential for oversights of this sort.  I believe >> that USER MAPPINGs

Re: [HACKERS] Comments on SQL/Med objects

2011-03-27 Thread Robert Haas
On Wed, Mar 23, 2011 at 12:53 PM, Tom Lane wrote: > Robert Haas writes: >> On Tue, Mar 22, 2011 at 6:23 PM, Guillaume Lelarge >> wrote: >>> While working on adding support for SQL/Med objects to pgAdmin, I'm >>> quite surprised to see there is no way to add comments to SQL/Med >>> objects. Is th

Re: [HACKERS] Comments on SQL/Med objects

2011-03-23 Thread Guillaume Lelarge
Le 23/03/2011 17:53, Tom Lane a écrit : > Robert Haas writes: >> On Tue, Mar 22, 2011 at 6:23 PM, Guillaume Lelarge >> wrote: >>> While working on adding support for SQL/Med objects to pgAdmin, I'm >>> quite surprised to see there is no way to add comments to SQL/Med >>> objects. Is this on purpo

Re: [HACKERS] Comments on SQL/Med objects

2011-03-23 Thread Tom Lane
Robert Haas writes: > On Tue, Mar 22, 2011 at 6:23 PM, Guillaume Lelarge > wrote: >> While working on adding support for SQL/Med objects to pgAdmin, I'm >> quite surprised to see there is no way to add comments to SQL/Med >> objects. Is this on purpose or is it just something that was simply miss

Re: [HACKERS] Comments on SQL/Med objects

2011-03-23 Thread Robert Haas
On Tue, Mar 22, 2011 at 6:23 PM, Guillaume Lelarge wrote: > While working on adding support for SQL/Med objects to pgAdmin, I'm > quite surprised to see there is no way to add comments to SQL/Med > objects. Is this on purpose or is it just something that was simply missed? I think it's an oversig

[HACKERS] Comments on SQL/Med objects

2011-03-22 Thread Guillaume Lelarge
Hi, While working on adding support for SQL/Med objects to pgAdmin, I'm quite surprised to see there is no way to add comments to SQL/Med objects. Is this on purpose or is it just something that was simply missed? Thanks. -- Guillaume http://www.postgresql.fr http://dalibo.com -- Sent via