Re: [HACKERS] Comment in snapbuild.c file

2017-08-13 Thread Masahiko Sawada
On Sun, Aug 13, 2017 at 12:28 PM, Alvaro Herrera wrote: > Alvaro Herrera wrote: >> Masahiko Sawada wrote: >> > Hi all, >> > >> > In snapbuild.c file, there is a comment as follows. >> > >> >* NB: Because of that xmax can be lower than xmin, because we only >> >* increase xmax when a catalo

Re: [HACKERS] Comment in snapbuild.c file

2017-08-12 Thread Alvaro Herrera
Alvaro Herrera wrote: > Masahiko Sawada wrote: > > Hi all, > > > > In snapbuild.c file, there is a comment as follows. > > > >* NB: Because of that xmax can be lower than xmin, because we only > >* increase xmax when a catalog modifying transaction commits. While odd > >* looking, it'

Re: [HACKERS] Comment in snapbuild.c file

2017-08-10 Thread Alvaro Herrera
Masahiko Sawada wrote: > Hi all, > > In snapbuild.c file, there is a comment as follows. > >* NB: Because of that xmax can be lower than xmin, because we only >* increase xmax when a catalog modifying transaction commits. While odd >* looking, it's correct and actually more efficient

[HACKERS] Comment in snapbuild.c file

2017-08-09 Thread Masahiko Sawada
Hi all, In snapbuild.c file, there is a comment as follows. * NB: Because of that xmax can be lower than xmin, because we only * increase xmax when a catalog modifying transaction commits. While odd * looking, it's correct and actually more efficient this way since we hit * fast paths