Re: [HACKERS] Call for objections: put back OIDs in CREATE TABLE AS/SELECT

2003-01-26 Thread Bruce Momjian
Ross, you make some powerful arguments here. Probably the most significant was the idea that you need a unique identifier for every row, and it should be of a consistent type, which primary key is not. We clearly need a GUC parameter to turn on/off oids. But it seems we will always need the abi

Re: [HACKERS] Call for objections: put back OIDs in CREATE TABLE AS/SELECT INTO

2003-01-23 Thread Ross J. Reedstrom
On Thu, Jan 23, 2003 at 10:03:28AM -0500, Tom Lane wrote: > Curt Sampson <[EMAIL PROTECTED]> writes: > > I object. I personally think we should be moving towards not using OIDs > > as the default behaviour, inasmuch as we can, for several reasons: > > All these objections are global in nature, not

Re: [HACKERS] Call for objections: put back OIDs in CREATE TABLE AS/SELECT INTO

2003-01-23 Thread Tom Lane
Curt Sampson <[EMAIL PROTECTED]> writes: > I object. I personally think we should be moving towards not using OIDs > as the default behaviour, inasmuch as we can, for several reasons: All these objections are global in nature, not specific to CREATE TABLE AS. The argument that persuaded me to do

Re: [HACKERS] Call for objections: put back OIDs in CREATE TABLE AS/SELECT INTO

2003-01-22 Thread Christopher Kings-Lynne
> "Christopher Kings-Lynne" <[EMAIL PROTECTED]> writes: > > Why don't you just include them by default, otherwise if WITHOUT OIDS > > appears in the CREATE TABLE command, then don't include them ? > > Well, adding a WITHOUT OIDS option to CREATE TABLE AS would be a new > feature, which I don't have

Re: [HACKERS] Call for objections: put back OIDs in CREATE TABLE AS/SELECT INTO

2003-01-22 Thread Tom Lane
"Christopher Kings-Lynne" <[EMAIL PROTECTED]> writes: > Why don't you just include them by default, otherwise if WITHOUT OIDS > appears in the CREATE TABLE command, then don't include them ? Well, adding a WITHOUT OIDS option to CREATE TABLE AS would be a new feature, which I don't have the time/i

Re: [HACKERS] Call for objections: put back OIDs in CREATE TABLE AS/SELECT INTO

2003-01-21 Thread Christopher Kings-Lynne
uary 2003 4:12 AM > To: [EMAIL PROTECTED] > Subject: [HACKERS] Call for objections: put back OIDs in CREATE TABLE > AS/SELECT INTO > > > We've gotten a couple of complaints now about the fact that 7.3 doesn't > include an OID column in a table created via CREATE TABLE AS o

[HACKERS] Call for objections: put back OIDs in CREATE TABLE AS/SELECT INTO

2003-01-21 Thread Tom Lane
We've gotten a couple of complaints now about the fact that 7.3 doesn't include an OID column in a table created via CREATE TABLE AS or SELECT INTO. Unless I hear objections, I'm going to revert it to including an OID, and back-patch the fix for 7.3.2 as well. See discussion a couple days ago on