Re: [HACKERS] Bugs in our Windows socket code

2012-05-14 Thread Tom Lane
I wrote: > I've been trying to figure out why my recent attempt to latch-ify the > stats collector didn't work well on the Windows buildfarm machines. > ... > What I intend to try doing about this is making > pgwin32_waitforsinglesocket detach its event object from the socket before > returning, ie

Re: [HACKERS] Bugs in our Windows socket code

2012-05-13 Thread james
That is, if you request FD_WRITE events for a pre-existing socket with WSAEventSelect, you will not get one until the outbound network buffer has been filled and then has partially emptied. (This is incredibly broken, but Microsoft evidently has no intention of fixing it.) I think you should di

[HACKERS] Bugs in our Windows socket code

2012-05-13 Thread Tom Lane
I've been trying to figure out why my recent attempt to latch-ify the stats collector didn't work well on the Windows buildfarm machines. After a good deal of staring at our code and Microsoft's documentation I have a theory, which I intend to try out shortly. However, it appears to me that this c