On 12/4/14 3:47 PM, Andrew Dunstan wrote:
> You have broken two buildfarm instances that build and test external
> modules - in one case the Redis FDW module and in the other the File
> Text Array FDW. I will see what can be retrieved.
This has been fixed.
One thing I'll look into sometime is spl
On 12/04/2014 03:47 PM, Andrew Dunstan wrote:
On 12/04/2014 02:44 PM, Peter Eisentraut wrote:
On 12/4/14 11:38 AM, Peter Eisentraut wrote:
On 11/19/14 11:11 PM, Peter Eisentraut wrote:
I noticed this item was still in the 9.4 code. Looking at the
original
submission
(http://www.postgresql.
On 12/04/2014 02:44 PM, Peter Eisentraut wrote:
On 12/4/14 11:38 AM, Peter Eisentraut wrote:
On 11/19/14 11:11 PM, Peter Eisentraut wrote:
I noticed this item was still in the 9.4 code. Looking at the original
submission
(http://www.postgresql.org/message-id/201306181552.36673.ced...@2ndquadr
On 12/4/14 11:38 AM, Peter Eisentraut wrote:
> On 11/19/14 11:11 PM, Peter Eisentraut wrote:
>> I noticed this item was still in the 9.4 code. Looking at the original
>> submission
>> (http://www.postgresql.org/message-id/201306181552.36673.ced...@2ndquadrant.com,
>> patch 0001), I think the origi
On 11/19/14 11:11 PM, Peter Eisentraut wrote:
> I noticed this item was still in the 9.4 code. Looking at the original
> submission
> (http://www.postgresql.org/message-id/201306181552.36673.ced...@2ndquadrant.com,
> patch 0001), I think the original reason for adding this was wrong to
> begin wit
On Wed, Nov 19, 2014 at 11:11 PM, Peter Eisentraut wrote:
> The applicable parts of
> that patch could be backpatched as a bug fix (but evidently no one cares
> about building contrib with pgxs (except when I submit a patch to remove
> it)).
Touché.
--
Robert Haas
EnterpriseDB: http://www.enter
On 1/31/14 9:28 PM, Bruce Momjian wrote:
> On Fri, Jan 31, 2014 at 09:28:06PM -0500, Andrew Dunstan wrote:
>>
>> On 01/31/2014 09:19 PM, Bruce Momjian wrote:
>>> On Thu, Oct 10, 2013 at 11:00:30PM -0400, Andrew Dunstan wrote:
On 10/10/2013 09:35 PM, Peter Eisentraut wrote:
> On Tue, 2013-1
On 6/18/13 9:52 AM, Cédric Villemain wrote:
> 0006-Fix-suggested-layout-for-extension.patch
I have committed this patch.
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Fri, Jan 31, 2014 at 09:28:06PM -0500, Andrew Dunstan wrote:
>
> On 01/31/2014 09:19 PM, Bruce Momjian wrote:
> >On Thu, Oct 10, 2013 at 11:00:30PM -0400, Andrew Dunstan wrote:
> >>On 10/10/2013 09:35 PM, Peter Eisentraut wrote:
> >>>On Tue, 2013-10-08 at 10:04 -0400, Andrew Dunstan wrote:
> >>
On 01/31/2014 09:19 PM, Bruce Momjian wrote:
On Thu, Oct 10, 2013 at 11:00:30PM -0400, Andrew Dunstan wrote:
On 10/10/2013 09:35 PM, Peter Eisentraut wrote:
On Tue, 2013-10-08 at 10:04 -0400, Andrew Dunstan wrote:
On 10/07/2013 08:47 PM, Peter Eisentraut wrote:
I suspect this line
submake-l
On Thu, Oct 10, 2013 at 11:00:30PM -0400, Andrew Dunstan wrote:
>
> On 10/10/2013 09:35 PM, Peter Eisentraut wrote:
> >On Tue, 2013-10-08 at 10:04 -0400, Andrew Dunstan wrote:
> >>On 10/07/2013 08:47 PM, Peter Eisentraut wrote:
> >>>I suspect this line
> >>>
> >>>submake-libpq: $(libdir)/libpq.so
Le jeudi 10 octobre 2013 21:37:24 Peter Eisentraut a écrit :
> On Mon, 2013-10-07 at 22:00 -0400, Andrew Dunstan wrote:
> > The code has been sitting in HEAD for several months, and I
> > committed on the back branches because it was wanted.
>
> New features normally go through a full development
On 10/10/2013 09:35 PM, Peter Eisentraut wrote:
On Tue, 2013-10-08 at 10:04 -0400, Andrew Dunstan wrote:
On 10/07/2013 08:47 PM, Peter Eisentraut wrote:
I suspect this line
submake-libpq: $(libdir)/libpq.so ;
will cause problems on platforms with a different extension (e.g. OS X).
suggeste
On 10/10/2013 09:37 PM, Peter Eisentraut wrote:
On Mon, 2013-10-07 at 22:00 -0400, Andrew Dunstan wrote:
The code has been sitting in HEAD for several months, and I
committed on the back branches because it was wanted.
New features normally go through a full development cycle including
extensi
On Mon, 2013-10-07 at 22:00 -0400, Andrew Dunstan wrote:
> The code has been sitting in HEAD for several months, and I
> committed on the back branches because it was wanted.
New features normally go through a full development cycle including
extensive beta testing, especially when they contain
On Tue, 2013-10-08 at 10:04 -0400, Andrew Dunstan wrote:
> On 10/07/2013 08:47 PM, Peter Eisentraut wrote:
> >
> > I suspect this line
> >
> > submake-libpq: $(libdir)/libpq.so ;
> >
> > will cause problems on platforms with a different extension (e.g. OS X).
>
>
> suggested fix is below.
Hmm, t
On 10/07/2013 08:47 PM, Peter Eisentraut wrote:
I suspect this line
submake-libpq: $(libdir)/libpq.so ;
will cause problems on platforms with a different extension (e.g. OS X).
suggested fix is below.
cheers
andrew
diff --git a/src/Makefile.global.in b/src/Makefile.global.in
index bb732
On 10/07/2013 08:47 PM, Peter Eisentraut wrote:
On Sun, 2013-09-29 at 19:09 -0400, Andrew Dunstan wrote:
On 09/03/2013 04:04 AM, Cédric Villemain wrote:
Simple one, attached.
I didn't document USE_VPATH, not sure how to explain that clearly.
Just a remember that the doc is written and is wait
On Sun, 2013-09-29 at 19:09 -0400, Andrew Dunstan wrote:
> On 09/03/2013 04:04 AM, Cédric Villemain wrote:
> >> Simple one, attached.
> >> I didn't document USE_VPATH, not sure how to explain that clearly.
> > Just a remember that the doc is written and is waiting to be commited.
> >
> > There is a
Le lundi 30 septembre 2013 00:10:09 Andrew Dunstan a écrit :
> On 09/29/2013 07:09 PM, Andrew Dunstan wrote:
> > On 09/03/2013 04:04 AM, Cédric Villemain wrote:
> >>> Simple one, attached.
> >>> I didn't document USE_VPATH, not sure how to explain that clearly.
> >>
> >> Just a remember that the d
On 09/29/2013 07:09 PM, Andrew Dunstan wrote:
On 09/03/2013 04:04 AM, Cédric Villemain wrote:
Simple one, attached.
I didn't document USE_VPATH, not sure how to explain that clearly.
Just a remember that the doc is written and is waiting to be commited.
There is also an issue spoted by Chris
On 09/03/2013 04:04 AM, Cédric Villemain wrote:
Simple one, attached.
I didn't document USE_VPATH, not sure how to explain that clearly.
Just a remember that the doc is written and is waiting to be commited.
There is also an issue spoted by Christoph with the installdirs prerequisite,
the atta
On 09/03/2013 04:02 AM, Cédric Villemain wrote:
Simple one, attached.
I didn't document USE_VPATH, not sure how to explain that clearly.
Just a remember that the doc is written and is waiting to be commited.
There is also an issue spoted by Christoph with the installdirs prerequisite,
the atta
> Simple one, attached.
> I didn't document USE_VPATH, not sure how to explain that clearly.
Just a remember that the doc is written and is waiting to be commited.
There is also an issue spoted by Christoph with the installdirs prerequisite,
the attached patch fix that.
Also, the bugfixes were
Le lundi 8 juillet 2013 21:46:39, Andrew Dunstan a écrit :
> On 07/08/2013 03:40 PM, Josh Berkus wrote:
> > On 07/04/2013 06:18 AM, Andrew Dunstan wrote:
> >> On 07/04/2013 09:14 AM, Cédric Villemain wrote:
> >>> ah yes, good catch, I though .control file were unique per contrib,
> >>> but there ar
On 07/08/2013 12:51 PM, Josh Berkus wrote:
>
>> I think everything has been committed - as I think the CF app shows. The
>> only thing left in this srea from Cédric is the insallation of headers,
>> which Peter is down to review and is in "Waiting on Author" status.
>
> Yeah, that's the one I'm a
> I think everything has been committed - as I think the CF app shows. The
> only thing left in this srea from Cédric is the insallation of headers,
> which Peter is down to review and is in "Waiting on Author" status.
Yeah, that's the one I'm asking about. is that going to get done in the
next
On 07/08/2013 03:40 PM, Josh Berkus wrote:
On 07/04/2013 06:18 AM, Andrew Dunstan wrote:
On 07/04/2013 09:14 AM, Cédric Villemain wrote:
ah yes, good catch, I though .control file were unique per contrib,
but there aren't.
It's already been fixed.
Does it look like this patch will get into
On 07/04/2013 06:18 AM, Andrew Dunstan wrote:
>
> On 07/04/2013 09:14 AM, Cédric Villemain wrote:
>> ah yes, good catch, I though .control file were unique per contrib,
>> but there aren't.
>>
>>
>
> It's already been fixed.
Does it look like this patch will get into committable shape in the nex
On 07/04/2013 09:14 AM, Cédric Villemain wrote:
> > I'm not sure whether this is as simple as changing $< to $^ in the
> > pgxs.mk's installcontrol rule, or if something more is required.
> > Could you take a look?
> >
>
> will do.
ah yes, good catch, I though .control file were unique pe
> > I'm not sure whether this is as simple as changing $< to $^ in the
> > pgxs.mk's installcontrol rule, or if something more is required.
> > Could you take a look?
> >
>
> will do.
ah yes, good catch, I though .control file were unique per contrib, but there
aren't.
--
Cédric Villemain +33 (
On 07/03/2013 05:52 PM, Robert Haas wrote:
On Mon, Jul 1, 2013 at 5:04 PM, Andrew Dunstan wrote:
These changes are fairly small and mostly non-invasive, but if I've broken
something we should find out about it fairly quickly, I hope.
Turns out you broke something. Specifically, contrib/spi n
On Mon, Jul 1, 2013 at 5:04 PM, Andrew Dunstan wrote:
> These changes are fairly small and mostly non-invasive, but if I've broken
> something we should find out about it fairly quickly, I hope.
Turns out you broke something. Specifically, contrib/spi now only
installs autoinc.control instead of
On 07/01/2013 04:39 PM, Peter Eisentraut wrote:
On 6/29/13 1:54 PM, Andrew Dunstan wrote:
I haven't seen a response to this. One thing we are missing is
documentation. Given that I'm inclined to commit all of this (i.e.
cedric's patches 1,2,3, and 4 plus my addition).
Could someone post an upd
On 6/29/13 1:54 PM, Andrew Dunstan wrote:
> I haven't seen a response to this. One thing we are missing is
> documentation. Given that I'm inclined to commit all of this (i.e.
> cedric's patches 1,2,3, and 4 plus my addition).
Could someone post an updated set of patches that is currently under
co
Le samedi 29 juin 2013 22:00:34, Josh Berkus a écrit :
> On 06/29/2013 11:42 AM, Andrew Dunstan wrote:
> > I think we can survive for now without an additional tool. What I did
> > was a proof of concept, it was not intended as a suggestion that we
> > should install prep_buildtree. I am only sugge
On 06/29/2013 11:42 AM, Andrew Dunstan wrote:
>
> I think we can survive for now without an additional tool. What I did
> was a proof of concept, it was not intended as a suggestion that we
> should install prep_buildtree. I am only suggesting that, in addition to
> your changes, if USE_VPATH is s
On 06/29/2013 02:27 PM, Cédric Villemain wrote:
I haven't seen a response to this. One thing we are missing is
documentation. Given that I'm inclined to commit all of this (i.e.
cedric's patches 1,2,3, and 4 plus my addition).
I did so I sent the mail again. I believe your addition need some c
Le samedi 29 juin 2013 19:54:53, Andrew Dunstan a écrit :
> On 06/26/2013 10:52 AM, Andrew Dunstan wrote:
> > On 06/25/2013 11:29 AM, Cédric Villemain wrote:
> >> Le mardi 25 juin 2013 17:18:51, Andrew Dunstan a écrit :
> >>> On 06/24/2013 07:24 PM, Cédric Villemain wrote:
> Le mardi 25 juin 2
[it seems my first email didn't make it, sent again]
Le mercredi 26 juin 2013 16:52:01, Andrew Dunstan a écrit :
> On 06/25/2013 11:29 AM, Cédric Villemain wrote:
> > Le mardi 25 juin 2013 17:18:51, Andrew Dunstan a écrit :
> >> On 06/24/2013 07:24 PM, Cédric Villemain wrote:
> >>> Le mardi 25 jui
On 06/26/2013 10:52 AM, Andrew Dunstan wrote:
On 06/25/2013 11:29 AM, Cédric Villemain wrote:
Le mardi 25 juin 2013 17:18:51, Andrew Dunstan a écrit :
On 06/24/2013 07:24 PM, Cédric Villemain wrote:
Le mardi 25 juin 2013 00:18:26, Andrew Dunstan a écrit :
On 06/24/2013 04:02 PM, Cédric Vill
Le mercredi 26 juin 2013 16:52:01, Andrew Dunstan a écrit :
> On 06/25/2013 11:29 AM, Cédric Villemain wrote:
> > Le mardi 25 juin 2013 17:18:51, Andrew Dunstan a écrit :
> >> On 06/24/2013 07:24 PM, Cédric Villemain wrote:
> >>> Le mardi 25 juin 2013 00:18:26, Andrew Dunstan a écrit :
> On 06
On 06/25/2013 11:29 AM, Cédric Villemain wrote:
Le mardi 25 juin 2013 17:18:51, Andrew Dunstan a écrit :
On 06/24/2013 07:24 PM, Cédric Villemain wrote:
Le mardi 25 juin 2013 00:18:26, Andrew Dunstan a écrit :
On 06/24/2013 04:02 PM, Cédric Villemain wrote:
WIth extension, we do have to set
Le mardi 25 juin 2013 17:18:51, Andrew Dunstan a écrit :
> On 06/24/2013 07:24 PM, Cédric Villemain wrote:
> > Le mardi 25 juin 2013 00:18:26, Andrew Dunstan a écrit :
> >> On 06/24/2013 04:02 PM, Cédric Villemain wrote:
> >>> WIth extension, we do have to set VPATH explicitely if we want to use
>
On 06/24/2013 07:24 PM, Cédric Villemain wrote:
Le mardi 25 juin 2013 00:18:26, Andrew Dunstan a écrit :
On 06/24/2013 04:02 PM, Cédric Villemain wrote:
WIth extension, we do have to set VPATH explicitely if we want to use
VPATH (note that contribs/extensions must not care that postgresql has
Le mardi 25 juin 2013 00:18:26, Andrew Dunstan a écrit :
> On 06/24/2013 04:02 PM, Cédric Villemain wrote:
> > WIth extension, we do have to set VPATH explicitely if we want to use
> > VPATH (note that contribs/extensions must not care that postgresql has
> > been built with or without VPATH set).
On 06/24/2013 04:02 PM, Cédric Villemain wrote:
WIth extension, we do have to set VPATH explicitely if we want to use VPATH
(note that contribs/extensions must not care that postgresql has been built
with or without VPATH set). My patches try to fix that.
No, this is exactly what I'm obje
Le lundi 24 juin 2013 19:40:19, Andrew Dunstan a écrit :
> On 06/18/2013 09:52 AM, Cédric Villemain wrote:
> > I've rebased the current set of pending patches I had, to fix pgxs and
> > added 2 new patches.
> >
> > Bugfixes have already been presented and sent in another thread, except
> > the las
On 06/18/2013 09:52 AM, Cédric Villemain wrote:
I've rebased the current set of pending patches I had, to fix pgxs and added 2
new patches.
Bugfixes have already been presented and sent in another thread, except the
last one which only fix comment in pgxs.mk.
The new feature consists in a new
On 6/20/13 1:21 AM, Craig Ringer wrote:
> Personally, I'm all for just using the local path when building the
> module, and the qualified path elsewhere. It requires only a relatively
> simple change, and I don't think that using "hstore.h" within hstore,
> and "contrib/hstore/hstore.h" elsewhere i
On 6/20/13 1:21 AM, Craig Ringer wrote:
> As you note, the other option is to just refer to extension headers by
> their unqualified name. I'm *really* not a fan of that idea due to the
> obvious clash possibilities with Pg's own headers or system headers,
> especially given that the whole idea of
> Opinions all?
>
> * Give up on being able to use one extension's header from another
> entirely, except in the special case of in-tree builds
There are already a good number of use cases with only hstore and intarray,
I'm in favor of this feature.
> * Install install-enabled contrib headers i
Le jeudi 20 juin 2013 05:26:21, Peter Eisentraut a écrit :
> On Wed, 2013-06-19 at 20:58 +0200, Cédric Villemain wrote:
> > I believe he answered the proposal to put all headers on the same flat
> > directory, instead of a tree.
>
> The headers are used as
>
> #include "hstore.h"
> #include "ltre
On 06/20/2013 11:26 AM, Peter Eisentraut wrote:
> 3) Install them in a different directory and require a different
> #include line. But then you have to change the existing uses as well,
> which would probably require moving files around.
If I understand you correctly, your concern seems to be w
On Wed, 2013-06-19 at 20:58 +0200, Cédric Villemain wrote:
> I believe he answered the proposal to put all headers on the same flat
> directory, instead of a tree.
The headers are used as
#include "hstore.h"
#include "ltree.h"
etc.
in the existing source code.
If you want to install the for us
Le mercredi 19 juin 2013 21:06:23, Alvaro Herrera a écrit :
> Peter Eisentraut wrote:
> > On 6/19/13 12:20 PM, Andrew Dunstan wrote:
> > > So you're saying to install extension headers, but into the main
> > > directory where we put server headers?
> >
> > Yes, if we choose to install some extensi
Peter Eisentraut wrote:
> On 6/19/13 12:20 PM, Andrew Dunstan wrote:
> > So you're saying to install extension headers, but into the main
> > directory where we put server headers?
>
> Yes, if we choose to install some extension headers, that is where we
> should put them.
The question of the nam
Le mercredi 19 juin 2013 18:48:21, Andrew Dunstan a écrit :
> On 06/19/2013 12:32 PM, Cédric Villemain wrote:
> > Le mercredi 19 juin 2013 18:20:11, Andrew Dunstan a écrit :
> >> On 06/19/2013 11:26 AM, Peter Eisentraut wrote:
> >>> On 6/19/13 10:19 AM, Andrew Dunstan wrote:
> What are they go
On 6/19/13 12:20 PM, Andrew Dunstan wrote:
> So you're saying to install extension headers, but into the main
> directory where we put server headers?
Yes, if we choose to install some extension headers, that is where we
should put them.
--
Sent via pgsql-hackers mailing list (pgsql-hackers@po
On 06/19/2013 12:32 PM, Cédric Villemain wrote:
Le mercredi 19 juin 2013 18:20:11, Andrew Dunstan a écrit :
On 06/19/2013 11:26 AM, Peter Eisentraut wrote:
On 6/19/13 10:19 AM, Andrew Dunstan wrote:
What are they going to be used for anyway? I rubbed up against this not
too long ago. Things
Le mercredi 19 juin 2013 18:20:11, Andrew Dunstan a écrit :
> On 06/19/2013 11:26 AM, Peter Eisentraut wrote:
> > On 6/19/13 10:19 AM, Andrew Dunstan wrote:
> >> What are they going to be used for anyway? I rubbed up against this not
> >> too long ago. Things will blow up if you use stuff from the
On 06/19/2013 11:26 AM, Peter Eisentraut wrote:
On 6/19/13 10:19 AM, Andrew Dunstan wrote:
What are they going to be used for anyway? I rubbed up against this not
too long ago. Things will blow up if you use stuff from the module and
the module isn't already loaded.
See transforms.
So you'
On 6/19/13 10:19 AM, Andrew Dunstan wrote:
> What are they going to be used for anyway? I rubbed up against this not
> too long ago. Things will blow up if you use stuff from the module and
> the module isn't already loaded.
See transforms.
--
Sent via pgsql-hackers mailing list (pgsql-hackers
On 06/19/2013 10:06 AM, Peter Eisentraut wrote:
On 6/19/13 5:55 AM, Cédric Villemain wrote:
Le mercredi 19 juin 2013 04:48:11, Peter Eisentraut a écrit :
On Tue, 2013-06-18 at 15:52 +0200, Cédric Villemain wrote:
This allows for example to install hstore header and be able to
include them
in
On 6/19/13 5:55 AM, Cédric Villemain wrote:
> Le mercredi 19 juin 2013 04:48:11, Peter Eisentraut a écrit :
>> On Tue, 2013-06-18 at 15:52 +0200, Cédric Villemain wrote:
>>> This allows for example to install hstore header and be able to
>>> include them
>>>
>>> in another extension like that:
>>>
Le mercredi 19 juin 2013 04:48:11, Peter Eisentraut a écrit :
> On Tue, 2013-06-18 at 15:52 +0200, Cédric Villemain wrote:
> > This allows for example to install hstore header and be able to
> > include them
> >
> > in another extension like that:
> > # include "contrib/hstore/hstore.h"
>
> Tha
On Tue, 2013-06-18 at 15:52 +0200, Cédric Villemain wrote:
> This allows for example to install hstore header and be able to
> include them
> in another extension like that:
>
> # include "contrib/hstore/hstore.h"
That's not going to work. hstore's header file is included as #include
"hstore.h
I've rebased the current set of pending patches I had, to fix pgxs and added 2
new patches.
Bugfixes have already been presented and sent in another thread, except the
last one which only fix comment in pgxs.mk.
The new feature consists in a new variable to allow the installation of
contrib he
68 matches
Mail list logo
