On Tue, Mar 31, 2015 at 12:22:39PM -0700, David Fetter wrote:
> On Tue, Mar 31, 2015 at 12:58:27PM -0400, Tom Lane wrote:
> > David Fetter writes:
> > > On Tue, Mar 31, 2015 at 10:34:45AM -0400, Adam Brightwell wrote:
> > >> Previously, zero was rejected, what does it do now? I'm sure it
> > >> re
On Tue, Mar 31, 2015 at 12:58:27PM -0400, Tom Lane wrote:
> David Fetter writes:
> > On Tue, Mar 31, 2015 at 10:34:45AM -0400, Adam Brightwell wrote:
> >> Previously, zero was rejected, what does it do now? I'm sure it
> >> represents 0 AD/CE, however, is that important enough to note
> >> given t
David Fetter writes:
> On Tue, Mar 31, 2015 at 10:34:45AM -0400, Adam Brightwell wrote:
>> Previously, zero was rejected, what does it do now? I'm sure it represents
>> 0 AD/CE, however, is that important enough to note given that it was not
>> allowed previously?
> Now, it's supposed to take 0 a
On Tue, Mar 31, 2015 at 10:34:45AM -0400, Adam Brightwell wrote:
> >
> > Good point. Next patch attached.
>
>
> /*
> - * Note: we'll reject zero or negative year values. Perhaps negatives
> - * should be allowed to represent BC years?
> + * Note: Non-positive years are taken to be BCE.
> */
>
> Good point. Next patch attached.
/*
- * Note: we'll reject zero or negative year values. Perhaps negatives
- * should be allowed to represent BC years?
+ * Note: Non-positive years are taken to be BCE.
*/
Previously, zero was rejected, what does it do now? I'm sure it represents
0 AD/C
On Mon, Mar 30, 2015 at 05:35:29PM -0500, Jim Nasby wrote:
> On 3/26/15 5:26 PM, David Fetter wrote:
> >+ * Note: Non-positive years are take to be BCE.
>
> s/take/taken/
Good point. Next patch attached.
Cheers,
David.
--
David Fetter http://fetter.org/
Phone: +1 415 235 3778 AIM: dfette
On 3/26/15 5:26 PM, David Fetter wrote:
+* Note: Non-positive years are take to be BCE.
s/take/taken/
--
Jim Nasby, Data Architect, Blue Treble Consulting
Data in Trouble? Get it in Treble! http://BlueTreble.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To
2015-03-26 23:26 GMT+01:00 David Fetter :
> Folks,
>
> For reasons unclear, dates before the Common Era are disallowed in
> make_date(), even though about 2/3 of the underlying data type's range
> up until the present time fits that description.
>
> Please find attached a patch fixing same.
>
+1
Folks,
For reasons unclear, dates before the Common Era are disallowed in
make_date(), even though about 2/3 of the underlying data type's range
up until the present time fits that description.
Please find attached a patch fixing same.
Cheers,
David.
--
David Fetter http://fetter.org/
Phone: +