Re: [HACKERS] Broken API specification for walrcv_receive

2016-04-14 Thread Thomas Munro
On Fri, Apr 15, 2016 at 4:28 AM, Tom Lane wrote: > I noticed thanks to a buildfarm warning that replication/walreceiver.h > now declares the walrcv_receive hook as > > typedef int (*walrcv_receive_type) (char **buffer, int *wait_fd); > > This is flat out wrong, isn't it? wait_fd needs to be of ty

[HACKERS] Broken API specification for walrcv_receive

2016-04-14 Thread Tom Lane
I noticed thanks to a buildfarm warning that replication/walreceiver.h now declares the walrcv_receive hook as typedef int (*walrcv_receive_type) (char **buffer, int *wait_fd); This is flat out wrong, isn't it? wait_fd needs to be of type pgsocket, which is a different width from "int" on Window