Re: [HACKERS] Broken --dry-run mode in pg_rewind

2015-05-08 Thread Vladimir Borodin
8 мая 2015 г., в 16:39, Vladimir Borodin написал(а):8 мая 2015 г., в 16:11, Stephen Frost написал(а):* Heikki Linnakangas (hlinn...@iki.fi) wrote:On 05/08/2015 03:39 PM, Michael Paquier wrote:On Fri, May 8, 2015 at 9:34 PM, Heikki Linnakangas

Re: [HACKERS] Broken --dry-run mode in pg_rewind

2015-05-08 Thread Vladimir Borodin
> 8 мая 2015 г., в 16:11, Stephen Frost написал(а): > > * Heikki Linnakangas (hlinn...@iki.fi ) wrote: >> On 05/08/2015 03:39 PM, Michael Paquier wrote: >>> On Fri, May 8, 2015 at 9:34 PM, Heikki Linnakangas wrote: On 05/08/2015 03:25 PM, Vladimir Borodin wrote: >>>

Re: [HACKERS] Broken --dry-run mode in pg_rewind

2015-05-08 Thread Stephen Frost
* Heikki Linnakangas (hlinn...@iki.fi) wrote: > On 05/08/2015 03:39 PM, Michael Paquier wrote: > >On Fri, May 8, 2015 at 9:34 PM, Heikki Linnakangas wrote: > >>On 05/08/2015 03:25 PM, Vladimir Borodin wrote: > >>>Seems, that pg_rewind does not account --dry-run option properly. A simple > >>>fix >

Re: [HACKERS] Broken --dry-run mode in pg_rewind

2015-05-08 Thread Heikki Linnakangas
On 05/08/2015 03:39 PM, Michael Paquier wrote: On Fri, May 8, 2015 at 9:34 PM, Heikki Linnakangas wrote: On 05/08/2015 03:25 PM, Vladimir Borodin wrote: Seems, that pg_rewind does not account --dry-run option properly. A simple fix for that is attached. No, the --dry-run takes effect later.

Re: [HACKERS] Broken --dry-run mode in pg_rewind

2015-05-08 Thread Michael Paquier
On Fri, May 8, 2015 at 9:34 PM, Heikki Linnakangas wrote: > On 05/08/2015 03:25 PM, Vladimir Borodin wrote: >> Seems, that pg_rewind does not account --dry-run option properly. A simple >> fix >> for that is attached. > > > No, the --dry-run takes effect later. It performs all the actions it > nor

Re: [HACKERS] Broken --dry-run mode in pg_rewind

2015-05-08 Thread Heikki Linnakangas
On 05/08/2015 03:25 PM, Vladimir Borodin wrote: Hi all. Seems, that pg_rewind does not account --dry-run option properly. A simple fix for that is attached. No, the --dry-run takes effect later. It performs all the actions it normally would, including reading files from the source, except for

[HACKERS] Broken --dry-run mode in pg_rewind

2015-05-08 Thread Vladimir Borodin
Hi all.Seems, that pg_rewind does not account --dry-run option properly. A simple fix for that is attached. pg_rewind_dry_run_fix.patch Description: Binary data --May the force be with you…https://simply.name