Re: [HACKERS] Bogus error handling in pg_upgrade

2014-01-09 Thread Bruce Momjian
On Sun, Dec 29, 2013 at 12:25:04AM -0500, Tom Lane wrote: > A credulous person might suppose that this chunk of code is designed > to abort if pg_resetxlog fails: > > prep_status("Setting next transaction ID for new cluster"); > exec_prog(UTILITY_LOG_FILE, NULL, true, > "\"%s

Re: [HACKERS] Bogus error handling in pg_upgrade

2014-01-01 Thread Robert Haas
On Sun, Dec 29, 2013 at 12:25 AM, Tom Lane wrote: > check_ok() is particularly badly named, since it contains not one iota > of error checking. misleadingly_claim_ok() would be a better name. That's pretty hilarious, actually. I think it probably started as a copy of initdb.c's check_ok(), and

[HACKERS] Bogus error handling in pg_upgrade

2013-12-28 Thread Tom Lane
A credulous person might suppose that this chunk of code is designed to abort if pg_resetxlog fails: prep_status("Setting next transaction ID for new cluster"); exec_prog(UTILITY_LOG_FILE, NULL, true, "\"%s/pg_resetxlog\" -f -x %u \"%s\"", new_cluster.bindir, ol