Re: [HACKERS] Bizarre reindex_relation API

2011-04-16 Thread Robert Haas
On Apr 16, 2011, at 11:52 AM, Tom Lane wrote: > Why in the world is reindex_relation defined like this? > > #define REINDEX_CHECK_CONSTRAINTS0x1 > #define REINDEX_SUPPRESS_INDEX_USE0x2 > extern bool reindex_relation(Oid relid, bool toast_too, int flags); > > Seems like a rational design

Re: [HACKERS] Bizarre reindex_relation API

2011-04-16 Thread Noah Misch
On Sat, Apr 16, 2011 at 11:52:47AM -0400, Tom Lane wrote: > Why in the world is reindex_relation defined like this? > > #define REINDEX_CHECK_CONSTRAINTS 0x1 > #define REINDEX_SUPPRESS_INDEX_USE0x2 > extern bool reindex_relation(Oid relid, bool toast_too, int flags); > > Seems like a rati

[HACKERS] Bizarre reindex_relation API

2011-04-16 Thread Tom Lane
Why in the world is reindex_relation defined like this? #define REINDEX_CHECK_CONSTRAINTS 0x1 #define REINDEX_SUPPRESS_INDEX_USE 0x2 extern bool reindex_relation(Oid relid, bool toast_too, int flags); Seems like a rational design would have folded toast_too in as another flag bit, inst