Re: [HACKERS] Better name for PQsslAttributes()

2015-11-07 Thread Lars Kanis
Am 07.11.2015 um 22:14 schrieb Tom Lane: > Pushed. I took the opportunity to fix the const-ness annotation of the > function result type, too. Great, thank you! -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org

Re: [HACKERS] Better name for PQsslAttributes()

2015-11-07 Thread Tom Lane
Lars Kanis writes: > Thank you for the quick response! Attached the last minute - now or > never patch to change the function name. Pushed. I took the opportunity to fix the const-ness annotation of the function result type, too. regards, tom lane -- Sent via pgsql-ha

Re: [HACKERS] Better name for PQsslAttributes()

2015-11-07 Thread Tom Lane
Lars Kanis writes: > Thank you for the quick response! Attached the last minute - now or > never patch to change the function name. Ah, thanks for doing the legwork. It's pretty late in the day Heikki's time, so I'll review and hopefully push this. regards, tom lane --

Re: [HACKERS] Better name for PQsslAttributes()

2015-11-07 Thread Tom Lane
Tom Lane writes: > Heikki Linnakangas writes: >> The question is, do we want to still change it? It's a new function in >> 9.5, and we're just about to enter beta, so I guess we could, although >> there might already be applications out there using it. If we do want to >> rename it, now is the

Re: [HACKERS] Better name for PQsslAttributes()

2015-11-07 Thread Lars Kanis
Thank you for the quick response! Attached the last minute - now or never patch to change the function name. In addition I perceived a small inconsistency with the naming of the SGML id of PQsslAttribute. This is addressed in the second patch file. -- Kind Regards, Lars From 5b7f116de237df540493

Re: [HACKERS] Better name for PQsslAttributes()

2015-11-06 Thread Tom Lane
Heikki Linnakangas writes: > On 11/06/2015 11:31 PM, Lars Kanis wrote: >> As a co-maintainer of the PostgreSQL adapter for Ruby, I would like to >> bridge the new SSL related functions to Ruby methods. However I wonder >> whether PQsslAttributes() is the best name for the function. Based on >> thi

Re: [HACKERS] Better name for PQsslAttributes()

2015-11-06 Thread Peter Geoghegan
On Fri, Nov 6, 2015 at 1:38 PM, Heikki Linnakangas wrote: > Thoughts? I'm leaning towards changing it now. +1 to the idea of changing it. -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/m

Re: [HACKERS] Better name for PQsslAttributes()

2015-11-06 Thread Magnus Hagander
On Fri, Nov 6, 2015 at 10:38 PM, Heikki Linnakangas wrote: > On 11/06/2015 11:31 PM, Lars Kanis wrote: > >> As a co-maintainer of the PostgreSQL adapter for Ruby, I would like to >> bridge the new SSL related functions to Ruby methods. However I wonder >> whether PQsslAttributes() is the best nam

Re: [HACKERS] Better name for PQsslAttributes()

2015-11-06 Thread Heikki Linnakangas
On 11/06/2015 11:31 PM, Lars Kanis wrote: As a co-maintainer of the PostgreSQL adapter for Ruby, I would like to bridge the new SSL related functions to Ruby methods. However I wonder whether PQsslAttributes() is the best name for the function. Based on this name, I would expect to get key+value

[HACKERS] Better name for PQsslAttributes()

2015-11-06 Thread Lars Kanis
As a co-maintainer of the PostgreSQL adapter for Ruby, I would like to bridge the new SSL related functions to Ruby methods. However I wonder whether PQsslAttributes() is the best name for the function. Based on this name, I would expect to get key+value pairs instead of only the keys. IMHO PQsslAt