Re: [HACKERS] Better auth errors from libpq

2008-09-12 Thread Andrew Chernow
David Fetter wrote: On Fri, Sep 12, 2008 at 12:30:12PM -0400, Alvaro Herrera wrote: Joshua D. Drake wrote: Heikki Linnakangas wrote: The only thing I would say here is that you point the URL to current which will be wrong in one release. Perhaps something that pulls the pgversion macro? We

Re: [HACKERS] Better auth errors from libpq

2008-09-12 Thread David Fetter
On Fri, Sep 12, 2008 at 12:30:12PM -0400, Alvaro Herrera wrote: > Joshua D. Drake wrote: > > Heikki Linnakangas wrote: > > > >>> The only thing I would say here is that you point the URL to > >>> current which will be wrong in one release. Perhaps something > >>> that pulls the pgversion macro? >

Re: [HACKERS] Better auth errors from libpq

2008-09-12 Thread Alvaro Herrera
Joshua D. Drake wrote: > Heikki Linnakangas wrote: > >>> The only thing I would say here is that you point the URL to current >>> which will be wrong in one release. Perhaps something that pulls the >>> pgversion macro? >> >> We don't put URLs in error messages. The hint needs to be a real sent

Re: [HACKERS] Better auth errors from libpq

2008-09-12 Thread Joshua D. Drake
Heikki Linnakangas wrote: The only thing I would say here is that you point the URL to current which will be wrong in one release. Perhaps something that pulls the pgversion macro? We don't put URLs in error messages. The hint needs to be a real sentence. Which is exactly why its the first

Re: [HACKERS] Better auth errors from libpq

2008-09-12 Thread David Fetter
On Fri, Sep 12, 2008 at 08:53:39AM +0100, Gregory Stark wrote: > > Tom Lane <[EMAIL PROTECTED]> writes: > > > Joshua Drake <[EMAIL PROTECTED]> writes: > >> I think something like: > > > >> psql: FATAL: Ident authentication failed for user "root" > >> HINT: http://www.postgresql.org/docs/8.3/stat

Re: [HACKERS] Better auth errors from libpq

2008-09-12 Thread David Fetter
On Fri, Sep 12, 2008 at 10:08:56AM +0200, Markus Schiltknecht wrote: > Hi, > > David Fetter wrote: >> I'm all for something, and that's a much better something. What we >> have now--nothing--actively distresses newbies for no good reason. >> >> I don't know how many people we've lost right at that

Re: [HACKERS] Better auth errors from libpq

2008-09-12 Thread Markus Wanner
Hi, David Fetter wrote: I'm all for something, and that's a much better something. What we have now--nothing--actively distresses newbies for no good reason. I don't know how many people we've lost right at that point, but the number has to be high, as most people don't just hop into IRC with

Re: [HACKERS] Better auth errors from libpq

2008-09-12 Thread Gregory Stark
Tom Lane <[EMAIL PROTECTED]> writes: > Joshua Drake <[EMAIL PROTECTED]> writes: >> I think something like: > >> psql: FATAL: Ident authentication failed for user "root" >> HINT: http://www.postgresql.org/docs/8.3/static/client-authentication.html > >> Would be nice. ... > > Or to put it even mor

Re: [HACKERS] Better auth errors from libpq

2008-09-11 Thread Heikki Linnakangas
Joshua D. Drake wrote: David Fetter wrote: On Thu, Sep 11, 2008 at 11:28:36PM -0400, Tom Lane wrote: Joshua Drake <[EMAIL PROTECTED]> writes: I think something like: psql: FATAL: Ident authentication failed for user "root" HINT: http://www.postgresql.org/docs/8.3/static/client-authentication

Re: [HACKERS] Better auth errors from libpq

2008-09-11 Thread Joshua D. Drake
David Fetter wrote: On Thu, Sep 11, 2008 at 11:28:36PM -0400, Tom Lane wrote: Joshua Drake <[EMAIL PROTECTED]> writes: I think something like: psql: FATAL: Ident authentication failed for user "root" HINT: http://www.postgresql.org/docs/8.3/static/client-authentication.html Would be nice. Do

Re: [HACKERS] Better auth errors from libpq

2008-09-11 Thread Joshua D. Drake
Tom Lane wrote: Joshua Drake <[EMAIL PROTECTED]> writes: I think something like: psql: FATAL: Ident authentication failed for user "root" HINT: http://www.postgresql.org/docs/8.3/static/client-authentication.html Would be nice. Do you really think that's helpful in the typical case wher

Re: [HACKERS] Better auth errors from libpq

2008-09-11 Thread David Fetter
On Thu, Sep 11, 2008 at 11:28:36PM -0400, Tom Lane wrote: > Joshua Drake <[EMAIL PROTECTED]> writes: > > I think something like: > > > psql: FATAL: Ident authentication failed for user "root" > > HINT: http://www.postgresql.org/docs/8.3/static/client-authentication.html > > > Would be nice. > >

Re: [HACKERS] Better auth errors from libpq

2008-09-11 Thread David Fetter
On Thu, Sep 11, 2008 at 11:28:36PM -0400, Tom Lane wrote: > Joshua Drake <[EMAIL PROTECTED]> writes: > > I think something like: > > > psql: FATAL: Ident authentication failed for user "root" > > HINT: http://www.postgresql.org/docs/8.3/static/client-authentication.html > > > Would be nice. > >

Re: [HACKERS] Better auth errors from libpq

2008-09-11 Thread Tom Lane
Joshua Drake <[EMAIL PROTECTED]> writes: > I think something like: > psql: FATAL: Ident authentication failed for user "root" > HINT: http://www.postgresql.org/docs/8.3/static/client-authentication.html > Would be nice. Do you really think that's helpful in the typical case where someone fat-fi

Re: [HACKERS] Better auth errors from libpq

2008-09-11 Thread David Fetter
On Thu, Sep 11, 2008 at 08:10:45PM -0700, Joshua D. Drake wrote: > On Thu, 11 Sep 2008 22:59:40 -0400 > Tom Lane <[EMAIL PROTECTED]> wrote: > > > > psql: FATAL: Ident authentication failed for user "root" > > > HINT: Is pg_hba.conf set properly on the server? > > > > Seems pretty useles

Re: [HACKERS] Better auth errors from libpq

2008-09-11 Thread Joshua Drake
On Thu, 11 Sep 2008 22:59:40 -0400 Tom Lane <[EMAIL PROTECTED]> wrote: > > psql: FATAL: Ident authentication failed for user "root" > > HINT: Is pg_hba.conf set properly on the server? > > Seems pretty useless. What does "set properly" mean? There isn't > even any good reason to think

Re: [HACKERS] Better auth errors from libpq

2008-09-11 Thread Tom Lane
David Fetter <[EMAIL PROTECTED]> writes: > This isn't exactly informative to newbies, so I'm proposing a patch > like that attached for such failures. Instead of seeing that > mysterious message, they'd get something like this: > psql: FATAL: Ident authentication failed for user "root" >

[HACKERS] Better auth errors from libpq

2008-09-11 Thread David Fetter
Folks, Far and away the most common question we get in IRC includes phrases like: psql: FATAL: Ident authentication failed for user "root" This isn't exactly informative to newbies, so I'm proposing a patch like that attached for such failures. Instead of seeing that mysterious message, th