Re: [HACKERS] Avoiding deeply nested AND/OR trees in the parser

2014-04-19 Thread Bruce Momjian
On Sat, Apr 19, 2014 at 05:50:17PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > On Wed, Feb 26, 2014 at 10:21:03PM -0500, Tom Lane wrote: > >> Oh, I'd forgotten about that thread. I never particularly liked the patch > >> as presented: like Robert, I thought it far too complicated. My > >>

Re: [HACKERS] Avoiding deeply nested AND/OR trees in the parser

2014-04-19 Thread Tom Lane
Bruce Momjian writes: > On Wed, Feb 26, 2014 at 10:21:03PM -0500, Tom Lane wrote: >> Oh, I'd forgotten about that thread. I never particularly liked the patch >> as presented: like Robert, I thought it far too complicated. My >> inclination would just be to tweak the parser enough so that a simp

Re: [HACKERS] Avoiding deeply nested AND/OR trees in the parser

2014-04-19 Thread Bruce Momjian
On Wed, Feb 26, 2014 at 10:21:03PM -0500, Tom Lane wrote: > Noah Misch writes: > > On Tue, Feb 25, 2014 at 01:15:09PM -0500, Tom Lane wrote: > >> Really if we wanted to fix > >> this issue we'd need to hack up transformAExprAnd/transformAExprOr so that > >> they recognized nested ANDs/ORs and flat

Re: [HACKERS] Avoiding deeply nested AND/OR trees in the parser

2014-02-26 Thread Ashutosh Bapat
On Thu, Feb 27, 2014 at 8:51 AM, Tom Lane wrote: > Noah Misch writes: > > On Tue, Feb 25, 2014 at 01:15:09PM -0500, Tom Lane wrote: > >> Really if we wanted to fix > >> this issue we'd need to hack up transformAExprAnd/transformAExprOr so > that > >> they recognized nested ANDs/ORs and flattened

Re: [HACKERS] Avoiding deeply nested AND/OR trees in the parser

2014-02-26 Thread Tom Lane
Noah Misch writes: > On Tue, Feb 25, 2014 at 01:15:09PM -0500, Tom Lane wrote: >> Really if we wanted to fix >> this issue we'd need to hack up transformAExprAnd/transformAExprOr so that >> they recognized nested ANDs/ORs and flattened them on the spot. This >> might not be a bad idea, but it's s

Re: [HACKERS] Avoiding deeply nested AND/OR trees in the parser

2014-02-26 Thread Noah Misch
On Tue, Feb 25, 2014 at 01:15:09PM -0500, Tom Lane wrote: > Over in > http://www.postgresql.org/message-id/bay176-w382a9de827ebc8e602b7bbc5...@phx.gbl > there's a complaint about getting "stack depth limit exceeded" from a > query of the form > > select count(*) from gui_die_summary where (x_coord

[HACKERS] Avoiding deeply nested AND/OR trees in the parser

2014-02-25 Thread Tom Lane
Over in http://www.postgresql.org/message-id/bay176-w382a9de827ebc8e602b7bbc5...@phx.gbl there's a complaint about getting "stack depth limit exceeded" from a query of the form select count(*) from gui_die_summary where (x_coord, y_coord) in ((25,5),(41,13),(25,7),(28,3),(25,8),(34,7),(26,6),(21,1