Re: [HACKERS] Array detection in pg_dump

2009-08-06 Thread Bruce Momjian
Bruce Momjian wrote: > Bruce Momjian wrote: > > Is there a reason we don't use pg_type.typcategory to detect arrays in > > Postgres 8.4? Right now I see this in pg_dump.c: > > > > if (g_fout->remoteVersion >= 80300) > > { > > appendPQExpBuffer(query, "SELECT tableoid, oid, typname, "

Re: [HACKERS] Array detection in pg_dump

2009-08-06 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian writes: > > Is there a reason we don't use pg_type.typcategory to detect arrays in > > Postgres 8.4? Right now I see this in pg_dump.c: > > typcategory is user-assignable and thus not too reliable; furthermore > it wouldn't prove that the type is the array type fo

Re: [HACKERS] Array detection in pg_dump

2009-08-06 Thread Bruce Momjian
Bruce Momjian wrote: > Is there a reason we don't use pg_type.typcategory to detect arrays in > Postgres 8.4? Right now I see this in pg_dump.c: > > if (g_fout->remoteVersion >= 80300) > { > appendPQExpBuffer(query, "SELECT tableoid, oid, typname, " > "typnam

Re: [HACKERS] Array detection in pg_dump

2009-08-06 Thread Tom Lane
Bruce Momjian writes: > Is there a reason we don't use pg_type.typcategory to detect arrays in > Postgres 8.4? Right now I see this in pg_dump.c: typcategory is user-assignable and thus not too reliable; furthermore it wouldn't prove that the type is the array type for its typelem. (Consider thi

[HACKERS] Array detection in pg_dump

2009-08-06 Thread Bruce Momjian
Is there a reason we don't use pg_type.typcategory to detect arrays in Postgres 8.4? Right now I see this in pg_dump.c: if (g_fout->remoteVersion >= 80300) { appendPQExpBuffer(query, "SELECT tableoid, oid, typname, " "typnamespace, "