Re: [HACKERS] Another refactoring proposal: move stuff into nodes/nodeFuncs.[ch]

2008-08-27 Thread Tom Lane
Simon Riggs <[EMAIL PROTECTED]> writes: > On Mon, 2008-08-25 at 11:24 -0400, Tom Lane wrote: >> The advantages of doing this would be (a) reduce the number of places >> to look in when implementing a new node type; (b) eliminate some >> cross-subsystem #inclusions that weaken modularity of the back

Re: [HACKERS] Another refactoring proposal: move stuff into nodes/nodeFuncs.[ch]

2008-08-27 Thread Simon Riggs
On Mon, 2008-08-25 at 11:24 -0400, Tom Lane wrote: > The advantages of doing this would be (a) reduce the number of places > to look in when implementing a new node type; (b) eliminate some > cross-subsystem #inclusions that weaken modularity of the backend. Are we doing either of those things i

[HACKERS] Another refactoring proposal: move stuff into nodes/nodeFuncs.[ch]

2008-08-25 Thread Tom Lane
So I was starting to implement an exprLocation() function according to previous discussion http://archives.postgresql.org/pgsql-hackers/2008-08/msg01131.php and I wondered where to put it. One idea is next to exprType() in parser/parse_expr.c, but that seems a bit unsatisfactory because it's likel