Re: [HACKERS] Additional logging for VACUUM and ANALYZE

2017-11-07 Thread Fabrízio de Royes Mello
On Tue, Nov 7, 2017 at 1:35 PM, Bossart, Nathan wrote: > > On 11/7/17, 9:13 AM, "Fabrízio Mello" wrote: > >> int save_nestlevel; > >> + boolrel_lock; > >> > > > > Just remove the additional tab indentation before rel_lock variable. > > I've removed the extra tab in v4. >

Re: [HACKERS] Additional logging for VACUUM and ANALYZE

2017-11-07 Thread Fabrízio Mello
The following review has been posted through the commitfest application: make installcheck-world: not tested Implements feature: tested, passed Spec compliant: tested, passed Documentation:tested, passed > int save_nestlevel; > + boolrel_lock;

Re: [HACKERS] Additional logging for VACUUM and ANALYZE

2017-11-07 Thread Fabrízio Mello
The following review has been posted through the commitfest application: make installcheck-world: not tested Implements feature: not tested Spec compliant: not tested Documentation:not tested The patch doesn't apply against master anymore: fabrizio@macanudo:/d/postgre

Re: [HACKERS] Additional logging for VACUUM and ANALYZE

2017-10-05 Thread Bossart, Nathan
On 10/5/17, 12:29 AM, "Michael Paquier" wrote: > On Thu, Oct 5, 2017 at 1:23 AM, Bossart, Nathan wrote: >> Presently, there are a few edge cases in vacuum_rel() and analyze_rel() that >> I >> believe do not have sufficient logging. This was discussed a bit in the >> vacuum-multiple-relations th

Re: [HACKERS] Additional logging for VACUUM and ANALYZE

2017-10-04 Thread Michael Paquier
On Thu, Oct 5, 2017 at 1:23 AM, Bossart, Nathan wrote: > Presently, there are a few edge cases in vacuum_rel() and analyze_rel() that I > believe do not have sufficient logging. This was discussed a bit in the > vacuum-multiple-relations thread [0], but it was ultimately decided that any > loggin