Re: [HACKERS] Add unistd.h to c.h

2011-03-11 Thread Tom Lane
Heikki Linnakangas writes: > On 11.03.2011 18:55, Bruce Momjian wrote: >> OK, I am just asking. FYI, we already include a boatload of includes in >> c.h: >> >> #include >> #include >> #include >> #include >> #include >> #ifdef HAVE_STRINGS_H >> #include >> #endif >> #ifdef HAVE_STDINT_H >> #incl

Re: [HACKERS] Add unistd.h to c.h

2011-03-11 Thread Alvaro Herrera
Excerpts from Heikki Linnakangas's message of vie mar 11 13:59:59 -0300 2011: > Presumably all of these are used by something in c.h itself. At least > strings.h is needed by memset, and stddef.h and/or stdlib.h is needed > for size_t. I'm too lazy to check the rest, but if there are any header

Re: [HACKERS] Add unistd.h to c.h

2011-03-11 Thread Heikki Linnakangas
On 11.03.2011 18:55, Bruce Momjian wrote: OK, I am just asking. FYI, we already include a boatload of includes in c.h: #include #include #include #include #include #ifdef HAVE_STRINGS_H #include #endif #ifdef HAVE_STDINT_H

Re: [HACKERS] Add unistd.h to c.h

2011-03-11 Thread Robert Haas
On Fri, Mar 11, 2011 at 11:53 AM, Bruce Momjian wrote: > Heikki Linnakangas wrote: >> On 11.03.2011 18:50, Bruce Momjian wrote: >> > Twenty percent of our C files include unistd.h.  Should we include >> > unistd.h in c.h and remove mentions of unistd.h in files that include >> > c.h? >> >> Why? >

Re: [HACKERS] Add unistd.h to c.h

2011-03-11 Thread Bruce Momjian
Heikki Linnakangas wrote: > On 11.03.2011 18:53, Bruce Momjian wrote: > > Heikki Linnakangas wrote: > >> On 11.03.2011 18:50, Bruce Momjian wrote: > >>> Twenty percent of our C files include unistd.h. Should we include > >>> unistd.h in c.h and remove mentions of unistd.h in files that include > >

Re: [HACKERS] Add unistd.h to c.h

2011-03-11 Thread Heikki Linnakangas
On 11.03.2011 18:53, Bruce Momjian wrote: Heikki Linnakangas wrote: On 11.03.2011 18:50, Bruce Momjian wrote: Twenty percent of our C files include unistd.h. Should we include unistd.h in c.h and remove mentions of unistd.h in files that include c.h? Why? Well, that is one less C include f

Re: [HACKERS] Add unistd.h to c.h

2011-03-11 Thread Robert Haas
On Fri, Mar 11, 2011 at 11:50 AM, Bruce Momjian wrote: > Twenty percent of our C files include unistd.h.  Should we include > unistd.h in c.h and remove mentions of unistd.h in files that include > c.h? Why? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Comp

Re: [HACKERS] Add unistd.h to c.h

2011-03-11 Thread Bruce Momjian
Heikki Linnakangas wrote: > On 11.03.2011 18:50, Bruce Momjian wrote: > > Twenty percent of our C files include unistd.h. Should we include > > unistd.h in c.h and remove mentions of unistd.h in files that include > > c.h? > > Why? Well, that is one less C include file in 151 C files, and just o

Re: [HACKERS] Add unistd.h to c.h

2011-03-11 Thread Heikki Linnakangas
On 11.03.2011 18:50, Bruce Momjian wrote: Twenty percent of our C files include unistd.h. Should we include unistd.h in c.h and remove mentions of unistd.h in files that include c.h? Why? -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com -- Sent via pgsql-hackers mailing l

[HACKERS] Add unistd.h to c.h

2011-03-11 Thread Bruce Momjian
Twenty percent of our C files include unistd.h. Should we include unistd.h in c.h and remove mentions of unistd.h in files that include c.h? -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + It's impossible for everything to be