Re: [HACKERS] Access to localized_str_tolower()

2008-07-01 Thread David E. Wheeler
On Jul 1, 2008, at 11:59, Tom Lane wrote: These are static --- that's why you can't get at them from outside the module. I think your best bet for an 8.3 version of citext is just to copy-and-paste a lot of code from HEAD. Well, that's what I'd done already; I was just trying to make it sim

Re: [HACKERS] Access to localized_str_tolower()

2008-07-01 Thread Tom Lane
"David E. Wheeler" <[EMAIL PROTECTED]> writes: > From formatting.c in 8.3.1: > static char *localized_str_toupper(char *buff); > static char *localized_str_tolower(char *buff); These are static --- that's why you can't get at them from outside the module. I think your best bet for an 8.3 version

Re: [HACKERS] Access to localized_str_tolower()

2008-07-01 Thread Bruce Momjian
David E. Wheeler wrote: > On Jul 1, 2008, at 11:11, Bruce Momjian wrote: > > > That whole use of localized_* is gone in CVS HEAD --- we now have a > > cleaner API. > > I know. The patch I sent in uses it. However, I still have a version I > want to use on 8.3. So what would be the proper functi

Re: [HACKERS] Access to localized_str_tolower()

2008-07-01 Thread David E. Wheeler
On Jul 1, 2008, at 11:11, Bruce Momjian wrote: That whole use of localized_* is gone in CVS HEAD --- we now have a cleaner API. I know. The patch I sent in uses it. However, I still have a version I want to use on 8.3. So what would be the proper function to use in 8.3.x and how can I get

Re: [HACKERS] Access to localized_str_tolower()

2008-07-01 Thread Bruce Momjian
David E. Wheeler wrote: > On Jul 1, 2008, at 10:38, Bruce Momjian wrote: > > >> Oh, and on a side note, should I localized_str_tolower() or just > >> str_tolower()? > > > > I am not sure what localized_str_tolower() is but I think you should > > call str_tolower directly if you want to pass char*

Re: [HACKERS] Access to localized_str_tolower()

2008-07-01 Thread David E. Wheeler
On Jul 1, 2008, at 10:38, Bruce Momjian wrote: Oh, and on a side note, should I localized_str_tolower() or just str_tolower()? I am not sure what localized_str_tolower() is but I think you should call str_tolower directly if you want to pass char*, and lower() if you want to pass 'text'.

Re: [HACKERS] Access to localized_str_tolower()

2008-07-01 Thread Bruce Momjian
David E. Wheeler wrote: > Howdy, > > In my original implementation of citext, which I'm going to start > using for an app I'm developing, I pull in the wstring_lower function > from oracle_compat.c by simply declaring it at the top of citext.c, > just as if it were in an include file: > >

[HACKERS] Access to localized_str_tolower()

2008-07-01 Thread David E. Wheeler
Howdy, In my original implementation of citext, which I'm going to start using for an app I'm developing, I pull in the wstring_lower function from oracle_compat.c by simply declaring it at the top of citext.c, just as if it were in an include file: extern char * wstring_lower (char *s